Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210322115602.4003221-1-arnd@kernel.org>
In-Reply-To: <20210322115602.4003221-1-arnd@kernel.org>
From:   Guenter Roeck <groeck@google.com>
Date:   Mon, 22 Mar 2021 07:14:12 -0700
Message-ID: <CABXOdTdePLDV91z4st2vErRLHEDn1ZD0x0AyO+JOwpatDQb17A@mail.gmail.com>
Subject: Re: [PATCH] platform/chrome: cros_ec_typec: fix clang -Wformat warning
To:     Arnd Bergmann <arnd@kernel.org>
Cc:     Benson Leung <bleung@chromium.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Nathan Chancellor <nathan@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        Prashant Malani <pmalani@chromium.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Guenter Roeck <groeck@chromium.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Azhar Shaikh <azhar.shaikh@intel.com>,
        Utkarsh Patel <utkarsh.h.patel@intel.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        clang-built-linux <clang-built-linux@googlegroups.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Mar 22, 2021 at 4:56 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> From: Arnd Bergmann <arnd@arndb.de>
>
> Clang warns about using the %h format modifier to truncate an
> integer:
>
> drivers/platform/chrome/cros_ec_typec.c:1031:3: error: format specifies type 'unsigned char' but the argument has type 'unsigned int' [-Werror,-Wformat]
>                 typec->pd_ctrl_ver);
>                 ^~~~~~~~~~~~~~~~~~
> include/linux/dev_printk.h:131:47: note: expanded from macro 'dev_dbg'
>                 dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
>                                                     ~~~     ^~~~~~~~~~~
>
> Use an explicit bit mask to limit the number to its lower eight bits
> instead.
>
> Fixes: ad7c0510c99e ("platform/chrome: cros_ec_typec: Update port info from EC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Guenter Roeck <groeck@chromium.org>

>
> ---
>  drivers/platform/chrome/cros_ec_typec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> index 0811562deecc..f07b7e946560 100644
> --- a/drivers/platform/chrome/cros_ec_typec.c
> +++ b/drivers/platform/chrome/cros_ec_typec.c
> @@ -1027,8 +1027,8 @@ static int cros_typec_get_cmd_version(struct cros_typec_data *typec)
>         else
>                 typec->pd_ctrl_ver = 0;
>
> -       dev_dbg(typec->dev, "PD Control has version mask 0x%hhx\n",
> -               typec->pd_ctrl_ver);
> +       dev_dbg(typec->dev, "PD Control has version mask 0x%02x\n",
> +               typec->pd_ctrl_ver & 0xff);
>
>         return 0;
>  }
> --
> 2.29.2
>