Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3487036pxf; Mon, 22 Mar 2021 07:34:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbrtvGrQJfLqx2hJVq+akhhsGXvYKzfyJb5w59Ds7CK46acxYrQ6oMrYP+k4+hsLAEuON+ X-Received: by 2002:aa7:d642:: with SMTP id v2mr26239666edr.257.1616423655695; Mon, 22 Mar 2021 07:34:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616423655; cv=none; d=google.com; s=arc-20160816; b=Pv7XhgMk04gsaNrZbjdhO496iZgoq1NmE2k8wYF8qsyDOoUxF9u88KBTKVFs+N18Ru 7cHtAPYVtzdqqgXn46m1fj3kAMnrSqYWpBdQI2HUzGA18JYSSipbpnWB0sRyL+/HUG76 nDk7sYUpkJU/LyQ/Qprqin0OybuQWVPA5m7a14/tIF33DnES0euM8s3XQKX+xy5MJpnu tn+SSpE20YDuSBGw1Wq66HYPmiQeJDmKY92D9zgteOHxt5+OS5IxxJAiLqOzGu7D0cfy YIPjxBaDvWTxsi7QOZg/OHrd7BslgkxZt7tEayTaBoKMO5JPzj4E+FXrC5Q55mj3n/WX Uhpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=L10f41YFPSYuLZ2Qn/bqjPBEJJpbB3QUZrKXGhgQjLM=; b=oThncRj97JlJJvgyK8tWaNwzXFk9IrRfxQqYQ1LnIkwXdhF9F7eStI1QEzLV2HqORy uFDWBvR0TX9w25zNoc946ha5pG1ZE54jfa3c7YKhqqiRRRs2QGRazASM/oCtWgGPQ7g/ 2PvS0tkEF3UD96VbeNzS/QF/vkjW3ZtdhQ9Kev90lKyfB/kPIDk8z5OEaxaBds/YW27r CDt581nOq3gtZdradIwo/ldf+HtP8YVX4MTkUKxXn3r3s2SuEaYepuXjBueSGjP1W0gW ML0lNViYiUmO1mnz8h92XD4oEDlQy/o4bEsBWGuVrRwmMLy53SiZq62pDwX0vZBsZHVG E0Tg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SsH5Ppja; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bc10si11497436edb.235.2021.03.22.07.33.52; Mon, 22 Mar 2021 07:34:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=SsH5Ppja; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231216AbhCVOdG (ORCPT + 99 others); Mon, 22 Mar 2021 10:33:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230422AbhCVOcf (ORCPT ); Mon, 22 Mar 2021 10:32:35 -0400 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E16ADC061756 for ; Mon, 22 Mar 2021 07:32:33 -0700 (PDT) Received: by mail-ej1-x635.google.com with SMTP id r12so21648485ejr.5 for ; Mon, 22 Mar 2021 07:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=L10f41YFPSYuLZ2Qn/bqjPBEJJpbB3QUZrKXGhgQjLM=; b=SsH5PpjaNiAR5wZ3sW4D3h0vSMAIljyr4ysm68wvsC74YowdUhSMbM3b9l+F0HvmBc 7HqaBPFNF/khVg/luG3nn4rxKj8tkTwy7frZw/qAnWO8jcxz9oZSEScuWGZGYREn4bqI ZW5M28IQ6jygp14eBvbIQOt2d4U5sEg8XJuA+H0qqvtu/+t1ETuzqAaSk+oph4NAnxS8 mZGjE7CUwVYyRlzjEjRdZooxA0A6duEQsvbDTZs4LZCB4hLUXtB99QTf4f1tm0+Jx/c0 kqxfu+w0Hk08OqjB+8iIty9iYAJdkksC+tdGwtm4Hzm3cxD9Ki0/NM1W44CBRG1r9uyK 0LJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=L10f41YFPSYuLZ2Qn/bqjPBEJJpbB3QUZrKXGhgQjLM=; b=mrH/oG67Sd/iP2IxGPYmCxX87Lhxzw0Mg/GS0Lct5f3xAN23o/5TE6Z8fz3hSI+gAz 1fDuG9SF4S/y2N982QpgOAaGs6TTTulPJ7a4Bwt9sjkYf55zX6B/elJ2jwiWnFCWFMrk nEJ/vEIeoy3W83O4Ynl1KZj9MjTLGv0c3YzJSPX895+7xNiprWXeJp1UP6bZaE68zr9h N4pFvVjCof2+B92xhvwbJkb/kZRMBUXlmuK39nSOWfeHwCk5ofVd15Ea/WdqiCHbOZSj 2tj84ZLF+jOo0P92TQfDt66CpIoskztX0nj9WlE/FuNsqskSGvQJh5FC2+f3D7b9W/21 twdw== X-Gm-Message-State: AOAM5329afUeLgXyJc0yvF52pibYVSBRS6ss1kMRE35G2jVQX8e2/IFV cdByYm7+Nta4ixb7QO5JeM1XzEXx5EuNtw== X-Received: by 2002:a17:906:d94:: with SMTP id m20mr19171558eji.511.1616423552688; Mon, 22 Mar 2021 07:32:32 -0700 (PDT) Received: from agape ([151.57.176.11]) by smtp.gmail.com with ESMTPSA id bx2sm11728567edb.80.2021.03.22.07.32.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Mar 2021 07:32:32 -0700 (PDT) From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: joe@perches.com, apw@canonical.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Fabio Aiuto Subject: [PATCH 09/11] staging: rtl8723bs: move function prototypes out of os_dep/int_fs.c Date: Mon, 22 Mar 2021 15:31:47 +0100 Message-Id: <9e1a40b86fb716d89bb12e5e3dfbe567a21fda6c.1616422773.git.fabioaiuto83@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix the following checkpatch issues: WARNING: externs should be avoided in .c files 196: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:196: +int _netdev_open(struct net_device *pnetdev); -- WARNING: externs should be avoided in .c files 197: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:197: +int netdev_open(struct net_device *pnetdev); moved function prototypes in include/osdep_intf.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/include/osdep_intf.h | 3 +++ drivers/staging/rtl8723bs/os_dep/os_intfs.c | 2 -- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/osdep_intf.h b/drivers/staging/rtl8723bs/include/osdep_intf.h index 5ad85416c598..dc279ceb1469 100644 --- a/drivers/staging/rtl8723bs/include/osdep_intf.h +++ b/drivers/staging/rtl8723bs/include/osdep_intf.h @@ -69,4 +69,7 @@ void rtw_ndev_destructor(struct net_device *ndev); int rtw_suspend_common(struct adapter *padapter); int rtw_resume_common(struct adapter *padapter); +int _netdev_open(struct net_device *pnetdev); +int netdev_open(struct net_device *pnetdev); + #endif /* _OSDEP_INTF_H_ */ diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index 9ae7d46fb501..3713c62a477c 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -193,8 +193,6 @@ MODULE_PARM_DESC(rtw_tx_pwr_lmt_enable, "0:Disable, 1:Enable, 2: Depend on efuse module_param(rtw_tx_pwr_by_rate, int, 0644); MODULE_PARM_DESC(rtw_tx_pwr_by_rate, "0:Disable, 1:Enable, 2: Depend on efuse"); -int _netdev_open(struct net_device *pnetdev); -int netdev_open(struct net_device *pnetdev); static int netdev_close(struct net_device *pnetdev); static void loadparam(struct adapter *padapter, struct net_device *pnetdev) -- 2.20.1