Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Manish Rangankar <mrangankar@marvell.com>
To:     Jia-Ju Bai <baijiaju1990@gmail.com>,
        Nilesh Javali <njavali@marvell.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] [PATCH] scsi: qedi: fix error return code of
 qedi_alloc_global_queues()
Thread-Topic: [EXT] [PATCH] scsi: qedi: fix error return code of
 qedi_alloc_global_queues()
Thread-Index: AQHXE8tn5bUdZsh0c028YzY1JItj5KqQK6sw
Date:   Mon, 22 Mar 2021 14:43:29 +0000
Message-ID: <BYAPR18MB299852960224776DF536EEA3D8659@BYAPR18MB2998.namprd18.prod.outlook.com>
References: <20210308033024.27147-1-baijiaju1990@gmail.com>
In-Reply-To: <20210308033024.27147-1-baijiaju1990@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 9e01dae2-97f3-4689-6bb8-08d8ed40dc3f
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2021 14:43:30.1239
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: c2zDNYJwGRFacgji9neNdV/GcoLwIrSMqw6FwAEZkXAJbBXbI3qs+v7ei+SpS+NqJJhNWNpuXeweMfvaEgK05w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR18MB3314
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761
 definitions=2021-03-22_07:2021-03-22,2021-03-22 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Jia-Ju Bai <baijiaju1990@gmail.com>
> Sent: Monday, March 8, 2021 9:00 AM
> To: Nilesh Javali <njavali@marvell.com>; Manish Rangankar
> <mrangankar@marvell.com>; jejb@linux.ibm.com;
> martin.petersen@oracle.com
> Cc: GR-QLogic-Storage-Upstream <GR-QLogic-Storage-
> Upstream@marvell.com>; linux-scsi@vger.kernel.org; linux-
> kernel@vger.kernel.org; Jia-Ju Bai <baijiaju1990@gmail.com>
> Subject: [EXT] [PATCH] scsi: qedi: fix error return code of
> qedi_alloc_global_queues()
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> When kzalloc() returns NULL to qedi->global_queues[i], no error return co=
de of
> qedi_alloc_global_queues() is assigned.
> To fix this bug, status is assigned with -ENOMEM in this case.
>=20
> Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI drive=
r
> framework.")
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
> ---
>  drivers/scsi/qedi/qedi_main.c | 1 +
>  1 file changed, 1 insertion(+)
>=20
> diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.=
c index
> 47ad64b06623..69c5b5ee2169 100644
> --- a/drivers/scsi/qedi/qedi_main.c
> +++ b/drivers/scsi/qedi/qedi_main.c
> @@ -1675,6 +1675,7 @@ static int qedi_alloc_global_queues(struct qedi_ctx
> *qedi)
>  		if (!qedi->global_queues[i]) {
>  			QEDI_ERR(&qedi->dbg_ctx,
>  				 "Unable to allocation global queue %d.\n", i);
> +			status =3D -ENOMEM;
>  			goto mem_alloc_failure;
>  		}
>=20
> --
> 2.17.1

Thanks,
Acked-by: Manish Rangankar <mrangankar@marvell.com>