Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 22 Mar 2021 11:01:06 -0400
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Qais Yousef <qais.yousef@arm.com>
Cc:     Alexander Sverdlin <alexander.sverdlin@nokia.com>,
        Ingo Molnar <mingo@redhat.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Ard Biesheuvel <ardb@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Florian Fainelli <f.fainelli@gmail.com>
Subject: Re: [PATCH v7 2/2] ARM: ftrace: Add MODULE_PLTS support
Message-ID: <20210322110106.2bed3d50@gandalf.local.home>
In-Reply-To: <20210321190611.d6a3hbqabts3qq5v@e107158-lin>
References: <20210127110944.41813-3-alexander.sverdlin@nokia.com>
        <20210307172650.uztx3sk5abybbp3f@e107158-lin.cambridge.arm.com>
        <0c122390-6e76-f773-86e9-8c085f4384f2@nokia.com>
        <20210309174201.n53za7mw33dqyleh@e107158-lin.cambridge.arm.com>
        <3eecf51d-b189-9e8b-f19d-a49d0764aae5@nokia.com>
        <05608bc8-f44d-5f91-15ab-af00c59b53e6@gmail.com>
        <e726be33-bc03-0515-f430-c5a34ebc3619@nokia.com>
        <20210312172401.36awjh4hmj4cs6ot@e107158-lin.cambridge.arm.com>
        <134e1a2c-daac-7b00-c170-bcca434d08df@gmail.com>
        <20210314220217.4mexdide7sqjfved@e107158-lin>
        <20210321190611.d6a3hbqabts3qq5v@e107158-lin>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Sun, 21 Mar 2021 19:06:11 +0000
Qais Yousef <qais.yousef@arm.com> wrote:

>  #ifdef CONFIG_DYNAMIC_FTRACE
>  struct dyn_arch_ftrace {
> -#ifdef CONFIG_ARM_MODULE_PLTS
>  	struct module *mod;
> -#endif
>  };
>  

I know you want to reduce the "ifdefery", but please note that the
dyn_arch_ftrace is defined once for every function that can be traced. If
you have 40,000 functions that can be traced, that pointer is created
40,000 times. Thus, you really only want fields in the struct
dyn_arch_ftrace if you really need them, otherwise, that's a lot of memory
that is wasted.

-- Steve