Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3514173pxf; Mon, 22 Mar 2021 08:09:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbs45I2J3Yokgu7XQbGluKEQX2e+/Ee43eZTySiZ6bk+UA2SMr3P4w/vvlSwoaGSCmzoWt X-Received: by 2002:a5d:4cc9:: with SMTP id c9mr11155117wrt.117.1616425785048; Mon, 22 Mar 2021 08:09:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616425785; cv=none; d=google.com; s=arc-20160816; b=j+j7ETO+OUjOLXGPmLjxriyyRsR73oylgQc8DGLD/bRXVvmwVqJUHUYhqW6A2tNGIe LXXSaH20wzbXmtref6Z5WePo2diMWTn9O8QcR/4ItFsDXGBx9FJ4U2nJ1kJg/sMdyFli IbYNXW6E82KMzCnsiutPLAmnyismlgRct2BtSBLTs8WchozCaZt8kULC12eIiRTnAJcT Sgj/w03vo3vIy89Fo4C/CZwMEhe7sZQPeueBXfLrE5XazrZ4xrRsQVMcLtu7royMCpZ9 Cv9FnfRHulkJNUj5UZ62ryBKx6r8A+6L2mhfpc+yhjLrY5iE0SU6SLCZDSXTnzHh8yci EkNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=8l1YAfM01tXTntKAIX6qfsyV5OQxcVjMXzy4jjecHzI=; b=be9J63bEM2VcuG8TNbzt25iX2mtanezRaQuDcQ/mgo9qIn3u7s3lEsSdkJPy9TyzY5 cY4wUVTpvPvTD36idfi8d5IvWu/0qMf+G8lGebqaG20twbYzptNHDlnCjn6AhqQ3oj91 NZbOJofcB0h1OGcK4CALtheEkmtF7X6x/qRhdtlx5QhrD7xsu1R38p7sZOOcZU6bBapo pE3qmGLZ0CRmbi1ObvrnBh11Q080FFP7RuvuPp6/pXHSUqzOarjxXhHfcV2a6eFlErz7 ZYQbZJgfG+0zQj2Zb5lk7A8RPNNtsnQtrsawO7uid/8T9gwBSX5Fxj5DY/qKjkEy2m7d epug== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m19si13084662eda.352.2021.03.22.08.09.21; Mon, 22 Mar 2021 08:09:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231479AbhCVPIY (ORCPT + 99 others); Mon, 22 Mar 2021 11:08:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:37530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231732AbhCVPHm (ORCPT ); Mon, 22 Mar 2021 11:07:42 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9F6876192E; Mon, 22 Mar 2021 15:07:38 +0000 (UTC) Date: Mon, 22 Mar 2021 11:07:37 -0400 From: Steven Rostedt To: Qais Yousef Cc: Peter Zijlstra , valentin.schneider@arm.com, tglx@linutronix.de, mingo@kernel.org, bigeasy@linutronix.de, swood@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vincent.donnefort@arm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] cpumask: Introduce DYING mask Message-ID: <20210322110737.221f4b78@gandalf.local.home> In-Reply-To: <20210321193037.7o3mqcmwjthbos7n@e107158-lin> References: <20210310145258.899619710@infradead.org> <20210310150109.151441252@infradead.org> <20210321193037.7o3mqcmwjthbos7n@e107158-lin> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 Mar 2021 19:30:37 +0000 Qais Yousef wrote: > On 03/10/21 15:53, Peter Zijlstra wrote: > > --- a/kernel/cpu.c > > +++ b/kernel/cpu.c > > @@ -160,6 +160,9 @@ static int cpuhp_invoke_callback(unsigne > > int (*cb)(unsigned int cpu); > > int ret, cnt; > > > > + if (bringup != !cpu_dying(cpu)) > > nit: this condition is hard to read Would if (bringup == !!cpu_dying(cpu)) read better? -- Steve > > > + set_cpu_dying(cpu, !bringup);