Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 22 Mar 2021 15:16:16 +0000
From:   Christoph Hellwig <hch@infradead.org>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     Christoph Hellwig <hch@infradead.org>, cohuck@redhat.com,
        kvm@vger.kernel.org, linux-kernel@vger.kernel.org, jgg@nvidia.com,
        peterx@redhat.com
Subject: Re: [PATCH v1 07/14] vfio: Add a device notifier interface
Message-ID: <20210322151616.GA2072680@infradead.org>
References: <161523878883.3480.12103845207889888280.stgit@gimli.home>
 <161524010999.3480.14282676267275402685.stgit@gimli.home>
 <20210310075639.GB662265@infradead.org>
 <20210319162540.0c5fe9dd@omen.home.shazbot.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210319162540.0c5fe9dd@omen.home.shazbot.org>
Precedence: bulk

On Fri, Mar 19, 2021 at 04:25:40PM -0600, Alex Williamson wrote:
> I've been trying to figure out how, but I think not.  A user can have
> multiple devices, each with entirely separate IOMMU contexts.  For each
> device, the user can create an mmap of memory to that device and add it
> to every other IOMMU context.  That enables peer to peer DMA between
> all the devices, across all the IOMMU contexts.  But each individual
> device has no direct reference to any IOMMU context other than its own.
> A callback on the IOMMU can't reach those other contexts either, there's
> no guarantee those other contexts are necessarily managed via the same
> vfio IOMMU backend driver.  A notifier is the best I can come up with,
> please suggest if you have other ideas.  Thanks,

Indeed, reviewing the set again it seems like we need the notifier
here.