Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3545701pxf; Mon, 22 Mar 2021 08:54:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxDFt0aDn/pm1iof19VJMfzavbRb3Cp89kFTd05yTZSCc3eHeZ9d47xhHyB4c1JZ6gCjwA X-Received: by 2002:aa7:c889:: with SMTP id p9mr252522eds.82.1616428475074; Mon, 22 Mar 2021 08:54:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616428475; cv=none; d=google.com; s=arc-20160816; b=tT2U/lgOe8f6cRXfAQ/evErItPriQdtKb2zTD2SlbR2/d2I0wiMBoe36AlqISYQLNT NdSR7nnd8eotVYZL246eOYFaivx1bS3yWmH4t2aTQfkWGvJJYFk3te5Yr77eu5CYpEka yjaJVCVz6XqIqU4QPoxWlMJUCgEmbjZRpwz72w/c2vp856d+F+ymF/vBiElo8dgwlZQ8 iaH6WU9tZYQOwEr0fabIniWrMAHOJYSfWWTOAe4NpmFUrjuybwZBoTBtJTj/4DEzAY1u 1WYq77JCIrq87zHatcWl1u+2kwmHwPwBecEziW+TYRzjADKaNxfXUSmJyMpPiw905yP2 IRQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=fyCFa+BDygLPuzAjxNv/tD9Go4dmhuuK/zx7vzstG0U=; b=UUsyJdBO2tqi5oEG1yRsCfUzeHlBwG1vD5xnn5nwvPBl4WX8A0yzrJhmBjwS6Ngj7O rXpwHUeOQCJw104fa3tNYb8+IsKbbk3ykBMK+1Vd5YC1lmLgmnodnSeGxZejFCCoFVYQ kBgY/B2/6Hs4hSidDsfqZlA/DBcze+fjD5WR1Tp1aFEksBC7smgDLtIQz+FCgeuUKU24 c/u1EqwpN9bqpxzG8qqP8J/1VIdj2IsTNEJXZIWwqh7wF0EKkEx6hv9FaUQzLZ6+Li9m lko54hXgC3+SbHk2ERoBkwflaGToKeON+W0kaHIB9G8lIzHAqhGP9vMerspMnlLcC/8t k4vA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bq17si12253345ejb.391.2021.03.22.08.54.12; Mon, 22 Mar 2021 08:54:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230154AbhCVPxT (ORCPT + 99 others); Mon, 22 Mar 2021 11:53:19 -0400 Received: from mga09.intel.com ([134.134.136.24]:47408 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbhCVPxJ (ORCPT ); Mon, 22 Mar 2021 11:53:09 -0400 IronPort-SDR: hJDC15ROJmIjjRcjEzfCEoGHFnOpi3T7LV1BMJDzYFMDbWgyxkaP/bcqrza35gxFXJjZDgsAMA brs93IcbcEFA== X-IronPort-AV: E=McAfee;i="6000,8403,9931"; a="190391719" X-IronPort-AV: E=Sophos;i="5.81,269,1610438400"; d="scan'208";a="190391719" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 08:53:07 -0700 IronPort-SDR: Z47juyE8m6ITb/B8rH3nG+QDylFyKXbk4DrllZ4mIzp4j9yqTR7dwTRtgnQcCikwZ2MaEmvjyq O4Adoixoz2qA== X-IronPort-AV: E=Sophos;i="5.81,269,1610438400"; d="scan'208";a="451782523" Received: from kaschuma-mobl1.amr.corp.intel.com (HELO [10.212.220.31]) ([10.212.220.31]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Mar 2021 08:53:05 -0700 Subject: Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy To: Perry Yuan , "Yuan, Perry" , "pobrn@protonmail.com" , "oder_chiou@realtek.com" , "perex@perex.cz" , "tiwai@suse.com" , "hdegoede@redhat.com" , "mgross@linux.intel.com" , "Limonciello, Mario" Cc: "linux-kernel@vger.kernel.org" , "alsa-devel@alsa-project.org" , "broonie@kernel.org" , "lgirdwood@gmail.com" , "platform-driver-x86@vger.kernel.org" References: <20210301093753.16300-1-Perry_Yuan@Dell.com> <551e30d2-0211-f3cb-fbb8-ee5b2f22a851@linux.intel.com> <58d2e2f2-e552-6ecf-b1c3-bf38ad5d2e35@gmail.com> From: Pierre-Louis Bossart Message-ID: <7e0fc125-5a26-47d6-aa2a-7cd1b2580adf@linux.intel.com> Date: Mon, 22 Mar 2021 09:49:48 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <58d2e2f2-e552-6ecf-b1c3-bf38ad5d2e35@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > As you suggested,I should add the alignment change in another patch. > But if i keep the old alignment, the code will be very odd. > Seems like that I have to change the below code to new alignment in this > patch. > > if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) && >     dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) { <<--- changed back >     if (!privacy_valid) >             has_privacy = true; >     else >             has_privacy = false; >     if (!has_privacy) { >         micmute_led_cdev.brightness <<----------- new alignment >         ... >     } > ... > } I don't get the point, sorry. The code above doesn't seem properly indented or there were spurious tab/spaces conversions?