Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3559384pxf; Mon, 22 Mar 2021 09:11:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxlfRBrg8s0dbMCVK6kmpG/4sirILlTIZgbX94itpOIeE4CGF/bq/O2Kk4YbJE9GHlGlTm2 X-Received: by 2002:a17:906:110d:: with SMTP id h13mr496722eja.357.1616429509858; Mon, 22 Mar 2021 09:11:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616429509; cv=none; d=google.com; s=arc-20160816; b=QPUKHb/3rlVZtq/JqoeDg7IEnzaxpwKXrm6pDmoYPdBc254hWA8+PXgaKlOldxfv+h CDumgWwaQ9UzYClrOG0CQYQq287PW0c/ereJwSTveqd75dVL0/qdiDoG12M2NXthh6ru E0W/FvoCdB1tuL7w7lyTSdptACapd05aEKQekfF8wMZ84DoL7mNkSBGOxdA0a966jT+V +InVY9GYwk7YKpgn6cpNxlEE7tYVKZSseg/mva1M9GYqnto+mvEvkcB11vpXpkUYO4yy 2bqBhEZ/VGAU3KM6MKtpbySzdXsU+W7KPPtH5mTQkoVx99pPAscx+VvQkVohONiVZvJZ iEtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=S29i7bd6FOozWas8rS1DW6tBMxgCKtYnB4t+J3MwDXM=; b=jXCb2Gt/vQ+0vvZaLMIasIhFUKwTZSzqT6FkPa4coeMQKcs41QseMYJX04ZITUX006 v47AcxhBKoaTmDIIvulLAKA4Koj4J8qO0XvbCfudXUmYgGUnfNFq2teOnhkEBOHMtqoP ATwbUOd3gBStPNYIWcY+tLOZeY9gtLCT8vbVi/qB6Mw7DnXpN2JPp7drJJgVLGxSK2PK 2CZ/4dxbIKMtL4JgfSnLele0HTij3oEus079jiDdqdlArWDnSV1iZfX3DvPzghAVYLzq XUqMGbrbDQ6JCUYP42l/KC/SPxPbSA0ZRqbrcPwNRbKxjg06LHWKMixhwI/tWUuJFUZI /f/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=D47G+25p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g18si12640654ejd.316.2021.03.22.09.11.26; Mon, 22 Mar 2021 09:11:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=D47G+25p; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230519AbhCVQIb (ORCPT + 99 others); Mon, 22 Mar 2021 12:08:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:54920 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231270AbhCVQIA (ORCPT ); Mon, 22 Mar 2021 12:08:00 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 15E07619B8; Mon, 22 Mar 2021 16:07:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616429276; bh=bqoeuGuZHclyiqqImlv9B3+pvikM/T3tAXBfmPztMmQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=D47G+25pfVObiOEQ9qddeviFeBgdbM0QJ28BZQPfmBDcUqRub5fih46R6ccse/DhD ukLw9iCqatyUK7H1y1+JzPJk+90NrXApke0bibWlcjXNSb8C7a+nEC1a2IPLiFg/F4 XW+CM0GdI3XR9de/ITa6TVeYOXmRWg6Lom+L9M0A= Date: Mon, 22 Mar 2021 17:07:53 +0100 From: Greg KH To: Fabio Aiuto Cc: joe@perches.com, apw@canonical.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote: > fix the following checkpatch issues: > > WARNING: externs should be avoided in .c files > 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: > +bool > > moved two function prototypes in include/rtw_efuse.h > > Signed-off-by: Fabio Aiuto > --- > drivers/staging/rtl8723bs/core/rtw_efuse.c | 10 ---------- > drivers/staging/rtl8723bs/include/rtw_efuse.h | 3 +++ > 2 files changed, 3 insertions(+), 10 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c > index 32ca10f01413..0772397738d4 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c > +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c > @@ -32,11 +32,6 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0}; > #define REG_EFUSE_CTRL 0x0030 > #define EFUSE_CTRL REG_EFUSE_CTRL /* E-Fuse Control. */ > > -bool > -Efuse_Read1ByteFromFakeContent( > - struct adapter *padapter, > - u16 Offset, > - u8 *Value); > bool > Efuse_Read1ByteFromFakeContent( > struct adapter *padapter, > @@ -53,11 +48,6 @@ Efuse_Read1ByteFromFakeContent( > return true; > } > > -bool > -Efuse_Write1ByteToFakeContent( > - struct adapter *padapter, > - u16 Offset, > - u8 Value); > bool > Efuse_Write1ByteToFakeContent( > struct adapter *padapter, > diff --git a/drivers/staging/rtl8723bs/include/rtw_efuse.h b/drivers/staging/rtl8723bs/include/rtw_efuse.h > index 5bae46ecd9de..1f304df8c421 100644 > --- a/drivers/staging/rtl8723bs/include/rtw_efuse.h > +++ b/drivers/staging/rtl8723bs/include/rtw_efuse.h > @@ -103,6 +103,9 @@ extern u8 fakeBTEfuseInitMap[]; > extern u8 fakeBTEfuseModifiedMap[]; > /*------------------------Export global variable----------------------------*/ > > +bool Efuse_Read1ByteFromFakeContent(struct adapter *padapter, u16 Offset, u8 *Value); > +bool Efuse_Write1ByteToFakeContent(struct adapter *padapter, u16 Offset, u8 Value); No, there's no need for this to be in a .h file, it is only called from one .c file. Make the thing static and all should be fine, right? thanks, greg k-h