Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3581851pxf; Mon, 22 Mar 2021 09:43:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxbF49+GZJkBv0ga/SyrmIAnNIhVKRhFs/k9PJ/UT+O6aOPPKGaqjn+Tm4vsxy3UgaFZU/T X-Received: by 2002:a17:906:e16:: with SMTP id l22mr666707eji.173.1616431384185; Mon, 22 Mar 2021 09:43:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616431384; cv=none; d=google.com; s=arc-20160816; b=H00zrDkzxCU8O/qviKoj2C/ps7h8yJCwUY8rVlCjvUOuhEsTvSUn3CN4I1SBr4EN1Q qAKItKhyBdXZHPuIKQ1h9dwZDwsb7xOxtVYNNOkVyMR6Y7WGy7dsYtWPyxbv8hcTISyw rh6RBisEd7gfG/FdlY692PMZmB3/06KOsHhcL6OUKuCBuk4lMPPhn2bZFgljbKS6l0Dz nPdwOANdFzefdma4oaOlMP1Zzk+qL13nCOGcfpwVAeoW+DDhMxplr52Ssicu7AdKuvpX gkWIm2Ffk6mCyteHz0KuLQzNOHOjLlughYxkRRVsIroN0Q8zTNOGWEROpho7UiRFjL52 FWbw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=IgrL5mIdmeSy6I7zsaU4xZX4Duo2hqTCb+3Lrwma16o=; b=Ur+FWTlJj8X6hOhpVq3zHxE0RNvvADlCVRdDGHRbqatkIQ0JDhk8SSC4ubezsdKS9B RIZtgEzUKnmvlT6vf1+JciLlmcy1lqTpnkydLJH8h8kwv91TokRWjNPJUMTsczdMRqCB xSgs/yoreivIgq5ZTSpt4wp2T+Di6Hp3s3DwdRfc/1ieVQpYQVgUlVpJUuEanHioB7Bb hV8U9mOzMIHu0oWqd7EbCzHScScYgDD1d7LCWWbgTpOCVpkDJqj7NSiQ/ZLf4CFsmWn+ EMYCo7IIJ+5OYinaNHFfuBHg7811uGhgGycAZ+82XuUZw7xW2NdfLYzUsemzDCdMVw+V u/UQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FPrmYxwL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h18si12176924eje.178.2021.03.22.09.42.41; Mon, 22 Mar 2021 09:43:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=FPrmYxwL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231952AbhCVQlv (ORCPT + 99 others); Mon, 22 Mar 2021 12:41:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:34736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231989AbhCVQlk (ORCPT ); Mon, 22 Mar 2021 12:41:40 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D3D6461983; Mon, 22 Mar 2021 16:41:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616431299; bh=wTCQr9EWReJqtv/s8uqRSPBYWLbukkFUAZ7BJJhYHhI=; h=From:To:Cc:Subject:Date:From; b=FPrmYxwLnsZstci9axXyytZZzCy9y3Cevl1KqesKwOuenXzXvlVzxhadzwKXI54mr aSjFBZSVdDt22a6tXaI7+rJMgbES/VMyJGT6D0V0jpWtdKNJjJBI7i+FF1Cxm2JvSz Df/icB4sJaXsfPKndnUEX+SJzndY/e/Moin0GZrEgqjqDA1WPy4+f/S3jS/eSYmgQR cX1/5h5kq98Nru1lJO0vBoWrejwnli8I7gsqb9nlCSypsvDhhCyy5J4kLgSCWnWpTO 6APc7UdRuJKkdl0BJr4RE5gCy+vyln4Nw7PNsov+iQZrMrG1+gfPGHmvVsIRo0WQH4 09iB9yXFo/YoA== From: Arnd Bergmann To: Lee Jones , Daniel Thompson , Jingoo Han , Kristoffer Ericson , Richard Purdie Cc: Arnd Bergmann , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] backlight: journada720: fix Wmisleading-indentation warning Date: Mon, 22 Mar 2021 17:41:28 +0100 Message-Id: <20210322164134.827091-1-arnd@kernel.org> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann With gcc-11, we get a warning about code that looks correct but badly indented: drivers/video/backlight/jornada720_bl.c: In function ‘jornada_bl_update_status’: drivers/video/backlight/jornada720_bl.c:66:11: error: this ‘else’ clause does not guard... [-Werror=misleading-indentation] 66 | } else /* turn on backlight */ | ^~~~ Change the formatting according to our normal conventions. Fixes: 13a7b5dc0d17 ("backlight: Adds HP Jornada 700 series backlight driver") Signed-off-by: Arnd Bergmann --- drivers/video/backlight/jornada720_bl.c | 44 ++++++++++++------------- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/video/backlight/jornada720_bl.c b/drivers/video/backlight/jornada720_bl.c index 996f7ba3b373..066d0dc98f60 100644 --- a/drivers/video/backlight/jornada720_bl.c +++ b/drivers/video/backlight/jornada720_bl.c @@ -66,30 +66,30 @@ static int jornada_bl_update_status(struct backlight_device *bd) } else /* turn on backlight */ PPSR |= PPC_LDD1; - /* send command to our mcu */ - if (jornada_ssp_byte(SETBRIGHTNESS) != TXDUMMY) { - dev_info(&bd->dev, "failed to set brightness\n"); - ret = -ETIMEDOUT; - goto out; - } + /* send command to our mcu */ + if (jornada_ssp_byte(SETBRIGHTNESS) != TXDUMMY) { + dev_info(&bd->dev, "failed to set brightness\n"); + ret = -ETIMEDOUT; + goto out; + } - /* - * at this point we expect that the mcu has accepted - * our command and is waiting for our new value - * please note that maximum brightness is 255, - * but due to physical layout it is equal to 0, so we simply - * invert the value (MAX VALUE - NEW VALUE). - */ - if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness) - != TXDUMMY) { - dev_err(&bd->dev, "set brightness failed\n"); - ret = -ETIMEDOUT; - } + /* + * at this point we expect that the mcu has accepted + * our command and is waiting for our new value + * please note that maximum brightness is 255, + * but due to physical layout it is equal to 0, so we simply + * invert the value (MAX VALUE - NEW VALUE). + */ + if (jornada_ssp_byte(BL_MAX_BRIGHT - bd->props.brightness) + != TXDUMMY) { + dev_err(&bd->dev, "set brightness failed\n"); + ret = -ETIMEDOUT; + } - /* - * If infact we get an TXDUMMY as output we are happy and dont - * make any further comments about it - */ + /* + * If infact we get an TXDUMMY as output we are happy and dont + * make any further comments about it + */ out: jornada_ssp_end(); -- 2.29.2