Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3599961pxf; Mon, 22 Mar 2021 10:09:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzOBcgYVJLMxctYSTWu2hRACA07b/IU37EgNutKvIpaeZkfl1QBS9bRBXie4/QMYazCuzOI X-Received: by 2002:a05:6402:cb8:: with SMTP id cn24mr608917edb.105.1616432980129; Mon, 22 Mar 2021 10:09:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616432980; cv=none; d=google.com; s=arc-20160816; b=P4DMJQd+Olmgo9/PTc1+KaT2jsg41PgrMwZ7AnAWL3zZTPsZyb7kSGeGz8t2aYwnIb I4HMZ83FnNfg/+8AnasINPymbo650oYdUmGsKElX7LJ/aXEqS4sdrjFoHSKlyQbA8d/l Hb8/LycNnQKV6AH9GUGh5+ys5H7SoSNUz2HwwVPu3qdLj7+4ps/9Hef2IPdvyVfN4x2c V/R2lKd+Z10EDmgwg2q85aH1EY6Gzynn3vRz/gwbHHsiz5YkocWTSjlhLXOk3L888N+X 1bOHUuCCq7TcDzeuXA6vbrpf+yYg05LEgM1C1w/0Dsb5kIyUU8ZUz7ZIuFYUY788mZEO VS6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=wLwToGxEDmc8n5o1OXi9U8H6a1AVaW5DdA44kJP/9pI=; b=Ecb7kr2PbzayrAdO2Zzlbzaq36tBwklnlS6nJ2obEj3+3T8LZrO/uI4DEaC2Wd4+1l XuQ306oelKUiNhQ0OxtLlZ4FUFUC+EGBtnfIUq+qCYgma/EbubG9ntKbrrKERVSPpMa2 YiY71k8xGMg/YEk2WfJ8dNouHBW5Zl64YmRaXVH6pKfPkM9b1MbLJEYUvadaZKNXuIXA iDC/mB9kXNvILIrkqGT0qfPo0wh99whN6qmPsexY/YbvdXSMnw1ZMs4UqawpTNdfQQdf 2C7IZCUrWHUZtXfWeOl+TkkkouSFe/jKjtAOxqjOpxXmFwcyTTYZvpGfCmSf64O5tdoi qV+w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Phg7D/qY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a7si11183074ejr.564.2021.03.22.10.09.17; Mon, 22 Mar 2021 10:09:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="Phg7D/qY"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229979AbhCVRIT (ORCPT + 99 others); Mon, 22 Mar 2021 13:08:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:29132 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231395AbhCVRHs (ORCPT ); Mon, 22 Mar 2021 13:07:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616432867; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wLwToGxEDmc8n5o1OXi9U8H6a1AVaW5DdA44kJP/9pI=; b=Phg7D/qY2CKp8bhVJ3fVDdnP/psm2kRsxa8QpO1cYZu3QfRZFRKTxN+wBeo3ob0kf7npWn z2uYYNR6jI2003E1rbrBxZKp5b/bSmnDhe+LqC0mN8+OyY/NnsCq3sTzPvcDNAnMCYPgdV /leR0UQZCCGzKkzQhEyexTKMx46n8RA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-343-JhkeyCoUMPurXEwlLsJ25g-1; Mon, 22 Mar 2021 13:07:43 -0400 X-MC-Unique: JhkeyCoUMPurXEwlLsJ25g-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 44D7C5B362; Mon, 22 Mar 2021 17:07:41 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.40.194.114]) by smtp.corp.redhat.com (Postfix) with SMTP id A916614106; Mon, 22 Mar 2021 17:07:38 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 22 Mar 2021 18:07:40 +0100 (CET) Date: Mon, 22 Mar 2021 18:07:34 +0100 From: Oleg Nesterov To: qianli zhao Cc: "Eric W. Biederman" , christian@brauner.io, axboe@kernel.dk, Thomas Gleixner , Peter Collingbourne , linux-kernel@vger.kernel.org, Qianli Zhao Subject: Re: [PATCH V3] exit: trigger panic when global init has exited Message-ID: <20210322170733.GE20390@redhat.com> References: <1615985460-112867-1-git-send-email-zhaoqianligood@gmail.com> <20210317143805.GA5610@redhat.com> <20210318180450.GA9977@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/22, qianli zhao wrote: > > Moving the decrement position should only affect between new and old > code position of movement of the decrement of > signal->live. Why do you think so? It can affect _any_ code which runs under "if (group_dead)". Again, I don't see anything wrong, but I didn't even try to audit these code paths. Oleg.