Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 22 Mar 2021 19:33:52 +0100
From:   Peter Zijlstra <peterz@infradead.org>
To:     Chris Hyser <chris.hyser@oracle.com>
Cc:     "Joel Fernandes (Google)" <joel@joelfernandes.org>,
        Nishanth Aravamudan <naravamudan@digitalocean.com>,
        Julien Desfossez <jdesfossez@digitalocean.com>,
        Tim Chen <tim.c.chen@linux.intel.com>,
        Vineeth Pillai <viremana@linux.microsoft.com>,
        Aaron Lu <aaron.lwe@gmail.com>,
        Aubrey Li <aubrey.intel@gmail.com>, tglx@linutronix.de,
        linux-kernel@vger.kernel.org, mingo@kernel.org,
        torvalds@linux-foundation.org, fweisbec@gmail.com,
        keescook@chromium.org, Phil Auld <pauld@redhat.com>,
        Valentin Schneider <valentin.schneider@arm.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
        Paolo Bonzini <pbonzini@redhat.com>, vineeth@bitbyteword.org,
        Chen Yu <yu.c.chen@intel.com>,
        Christian Brauner <christian.brauner@ubuntu.com>,
        Agata Gruza <agata.gruza@intel.com>,
        Antonio Gomez Iglesias <antonio.gomez.iglesias@intel.com>,
        graf@amazon.com, konrad.wilk@oracle.com, dfaggioli@suse.com,
        rostedt@goodmis.org, benbjiang@tencent.com,
        Alexandre Chartre <alexandre.chartre@oracle.com>,
        James.Bottomley@hansenpartnership.com, OWeisse@umich.edu,
        Dhaval Giani <dhaval.giani@oracle.com>,
        Josh Don <joshdon@google.com>, Hao Luo <haoluo@google.com>,
        Tom Lendacky <thomas.lendacky@amd.com>
Subject: Re: [PATCH 2/6] sched: tagging interface for core scheduling
Message-ID: <YFjjECKVskE01076@hirez.programming.kicks-ass.net>
References: <20210319203253.3352417-1-joel@joelfernandes.org>
 <20210319203253.3352417-3-joel@joelfernandes.org>
 <20210320154632.GZ4746@worktop.programming.kicks-ass.net>
 <ff9c63f2-0953-03c1-9b1c-25cb90954dee@oracle.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ff9c63f2-0953-03c1-9b1c-25cb90954dee@oracle.com>
Precedence: bulk

On Mon, Mar 22, 2021 at 01:57:48PM -0400, Chris Hyser wrote:
> On 3/20/21 11:46 AM, Peter Zijlstra wrote:
> > On Fri, Mar 19, 2021 at 04:32:49PM -0400, Joel Fernandes (Google) wrote:
> > > From: Josh Don <joshdon@google.com>
> > > 
> > > Adds per-task and per-cgroup interfaces for specifying which tasks can
> > > co-execute on adjacent SMT hyperthreads via core scheduling.
> > > 
> > > The per-task interface hooks are implemented here, but are not currently
> > > used. The following patch adds a prctl interface which then takes
> > > advantage of these.
> > > 
> > > The cgroup interface can be used to toggle a unique cookie value for all
> > > descendent tasks, preventing these tasks from sharing with any others.
> > > See Documentation/admin-guide/hw-vuln/core-scheduling.rst for a full
> > > rundown.
> > > 
> > > One important property of this interface is that neither the per-task
> > > nor the per-cgroup setting overrides the other. For example, if two
> > > tasks are in different cgroups, and one or both of the cgroups is tagged
> > > using the per-cgroup interface, then these tasks cannot share, even if
> > > they use the per-task interface to attempt to share with one another.
> > > 
> > > The above is implemented by making the overall core scheduling cookie a
> > > compound structure, containing both a task-level cookie and a
> > > group-level cookie. Two tasks will only be allowed to share if all
> > > fields of their respective cookies match.
> > > 
> > > Core scheduler has extra overhead.  Enable it only for machines with
> > > more than one SMT hardware thread.
> > 
> > Oh man.. I'd soooo hoped to first see the simple task interface and then
> > see the cgroup patch on top of that... I'll see if I can flip them
> > myself (on monday).
> 
> Peter, given we need to rebase this and we have some cleanup, we can go
> ahead and flip the order if you have not yet done so yet.

I didn't get around to it yet :/ So yes, please! Also can you then split
the selftest thingies?