Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3666792pxf; Mon, 22 Mar 2021 11:55:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwaYDhg1YJJ3S+L924CEQf3LoBCeCwgW9UOuKAiW7Mg3COJlnQzMVyoxzZeWe5U/ls/f82h X-Received: by 2002:a17:906:1b42:: with SMTP id p2mr1234778ejg.236.1616439329159; Mon, 22 Mar 2021 11:55:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616439329; cv=none; d=google.com; s=arc-20160816; b=wIdOlvjS6iD233AfKYMOezS8gzixwxaHV1RDRh5/uSB6gLyqObxhgKoc2crqO1hsS6 MRJrrvTNsTDH1DdyYI5Kb8vdUePBliPqdl/dgTpRm4/cuEwzHBzzvnZcl7VIICPN6nVV X+6jwNdo5zC7zdpXViV/z+3RdadDZZ8DQfTuA/mT3RwHVkgSPI9t5KOBL2Vxjs75xpSq FgksOfNr2oWLveQz1b0QMXVqsegvWW7XftAi+9VBvxPKl5O2OoGvzRCz//6So6hAgI96 DfjUtl/47qOtDZ9VC+AO3JRTxm+MoydUameuWD4tja5EDnZPNpA6aXSEiuUFow+ermtY mobQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=bfHMItw5sYe9vfijY6CHQKM2NFqGJk7w+Zph+e4TLQM=; b=ar2HevwsoVqwQIXuTNa5m3A8KAtXQ+ZSdnNcnyhnBq+PL7DSXv7RGMAmcE4bmWQIaR VjpuDAgHpyHWWIU4t4ignbm5qE6OoMwIoubsFD7NJnsqXMOEDv0iFUpphxsm5LDCAJSS 8My3vh9cuKGQlCbGE0NYnWIQri6y1HU/RF/7gsuKJSpg/Hm5wtEgIUl7EgezEN257Diz FOvKMazo4SA5L63Qmog01Z8gN0RIjna9RPdpTpMEK4Lwoc1Vafu5NzK6ChKWCKNDY8YR zDUeTC31mnfyhfD6Sero61djuZqgky93gDJLwQFVRJU+Tzip8+d5LNSZdgBF4OFvC4hu iAvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t14si11336314ejr.191.2021.03.22.11.55.06; Mon, 22 Mar 2021 11:55:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232272AbhCVSyQ (ORCPT + 99 others); Mon, 22 Mar 2021 14:54:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:37434 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231240AbhCVSxm (ORCPT ); Mon, 22 Mar 2021 14:53:42 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 12060619A1; Mon, 22 Mar 2021 18:53:42 +0000 (UTC) Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=why.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94) (envelope-from ) id 1lOPZS-0038p5-4Z; Mon, 22 Mar 2021 18:46:34 +0000 From: Marc Zyngier To: Lorenzo Pieralisi , Bjorn Helgaas Cc: Frank Wunderlich , Thierry Reding , Thomas Gleixner , Rob Herring , Will Deacon , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Michael Kelley , Wei Liu , Thierry Reding , Jonathan Hunter , Ryder Lee , Marek Vasut , Yoshihiro Shimoda , Michal Simek , Paul Walmsley , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, kernel-team@android.com Subject: [PATCH v2 11/15] PCI: mediatek: Advertise lack of MSI handling Date: Mon, 22 Mar 2021 18:46:10 +0000 Message-Id: <20210322184614.802565-12-maz@kernel.org> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20210322184614.802565-1-maz@kernel.org> References: <20210322184614.802565-1-maz@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: lorenzo.pieralisi@arm.com, bhelgaas@google.com, frank-w@public-files.de, treding@nvidia.com, tglx@linutronix.de, robh@kernel.org, will@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, sthemmin@microsoft.com, mikelley@microsoft.com, wei.liu@kernel.org, thierry.reding@gmail.com, jonathanh@nvidia.com, ryder.lee@mediatek.com, marek.vasut+renesas@gmail.com, yoshihiro.shimoda.uh@renesas.com, michal.simek@xilinx.com, paul.walmsley@sifive.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-tegra@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Gleixner Some Mediatek host bridges cannot handle MSIs, which is sad. This also results in an ugly warning at device probe time, as the core PCI code wasn't told that MSIs were not available. Advertise this fact to the rest of the core PCI code by using the 'no_msi' attribute. Acked-by: Bjorn Helgaas Reported-by: Frank Wunderlich Signed-off-by: Thomas Gleixner [maz: commit message] Signed-off-by: Marc Zyngier --- drivers/pci/controller/pcie-mediatek.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controller/pcie-mediatek.c index 23548b517e4b..ba28abdd1362 100644 --- a/drivers/pci/controller/pcie-mediatek.c +++ b/drivers/pci/controller/pcie-mediatek.c @@ -143,6 +143,7 @@ struct mtk_pcie_port; * struct mtk_pcie_soc - differentiate between host generations * @need_fix_class_id: whether this host's class ID needed to be fixed or not * @need_fix_device_id: whether this host's device ID needed to be fixed or not + * @no_msi: Bridge has no MSI support * @device_id: device ID which this host need to be fixed * @ops: pointer to configuration access functions * @startup: pointer to controller setting functions @@ -151,6 +152,7 @@ struct mtk_pcie_port; struct mtk_pcie_soc { bool need_fix_class_id; bool need_fix_device_id; + bool no_msi; unsigned int device_id; struct pci_ops *ops; int (*startup)(struct mtk_pcie_port *port); @@ -1087,6 +1089,7 @@ static int mtk_pcie_probe(struct platform_device *pdev) host->ops = pcie->soc->ops; host->sysdata = pcie; + host->no_msi = pcie->soc->no_msi; err = pci_host_probe(host); if (err) @@ -1176,6 +1179,7 @@ static const struct dev_pm_ops mtk_pcie_pm_ops = { }; static const struct mtk_pcie_soc mtk_pcie_soc_v1 = { + .no_msi = true, .ops = &mtk_pcie_ops, .startup = mtk_pcie_startup_port, }; -- 2.29.2