Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3670340pxf; Mon, 22 Mar 2021 12:01:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwJBKfGilaHpTvyNMXbLd3RqcSf+5SWqxsBpBiR4yegYQZInq0DXXZM+hAZyiG9V9EzWed/ X-Received: by 2002:a17:906:5acd:: with SMTP id x13mr1211995ejs.211.1616439690959; Mon, 22 Mar 2021 12:01:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616439690; cv=none; d=google.com; s=arc-20160816; b=iErJIOiewjBmW23zAa3RRvY9DL6+n39Jq75sPFNb3gGwxeJZF5ZTL9iA0S0szahKOu PP8weqs3gnJVnpgaL8G/06ZuwHeetWnz9kILP+w1p7g5nHbyneA+kokiIoGiY/jj8lOw w9Pu83e03uZxarVV6C1NWIjTreu3WyX6jZUW9ADmF5rVgWHWi7+++zVNMCS3tEjRNQlI B2jav3toFVh8uAiIcTy/+flcUcrEuhyyn49dGAUQIMXRURa4Cs1mCUVlJbCKijkZwBpc Yl+HACiwao0Vy5xUd7WKwhVyYkzzwLKHUOX6vQFDhnh4PL6lXHdSmkfAxlSTTvRSqJqh A8mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=scueAvaa7L4iGsVVzjKL9MF97LzjdUwe1FJJywyZru4=; b=iNT+hprO3Jt1uBwA/G+HRvnRC8/DkvNUrtroarNu3LkQcBe1FwUlG/6qmbdp9lXBxm sW+XUepZ+fM129qFPhkpbhvvKI5QevYo1UtWr40CH6JfNGpkrcyIVr/KYcYLkWVs1yAd Ebu1lrefQeBZwa+OZekpB7oHNFM71EelOaMgrrMJYEGIupaYAoh/c8ckpjea/VjJbXt4 teg1kBOPvJBJ5UFgEOf2M5SGSKcOeVnPCxstGkkjh1bgO7CqvbGBxSQIkAG4cKCRsaI+ Ho+ZKE7uzVeAZYAB545bXjhHIBWAWrVar8rvBK/PJUBBIlTSIthir3c3JjllXgEtr78Q fmkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SSE65I6P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v22si11264128edc.137.2021.03.22.12.01.06; Mon, 22 Mar 2021 12:01:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SSE65I6P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232329AbhCVS7n (ORCPT + 99 others); Mon, 22 Mar 2021 14:59:43 -0400 Received: from mail.kernel.org ([198.145.29.99]:40076 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232030AbhCVS7T (ORCPT ); Mon, 22 Mar 2021 14:59:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B511061994; Mon, 22 Mar 2021 18:59:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616439559; bh=ma5DQZiST6UuyaXhG1RK3qqQkaUKYMAQFWfliR48sPE=; h=From:To:Cc:Subject:Date:From; b=SSE65I6P2nTrfma4pzn7lsxd92K0aAl/O+XlncTRhO8W0n5ebTr9vJiqrSGp9SFU4 ZuF0GnSFVn9cAGDPux0FfqWjdO0+iYQsqrkuwY5exIOyI3baeOdK7kKv8RsFmIuYdU V/EptWkZNcZwK0+OM4XQMAUwKZck6lsb7syKaECwiwy8A+p05qeIqTbB5LH2mJTwrF ie89t+Tao0fEir6bV9rwwCgOTJqUJBl/eap9BV3oapVQ0gYdhpgwN8uIuUkiFW1Jgk PA7jyPVE5kP94PsnmLPjtk603Do6P80UFGHG9mxQXQIJ0M9+pbkBIBgI0m7OQrFTIq As88LluFAuPYg== From: Nicolas Saenz Julienne To: linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Saenz Julienne Cc: f.fainelli@gmail.com, phil@raspberrypi.com, tim.gover@raspberrypi.com, adrian.hunter@intel.com, sbranden@broadcom.com, alcooperx@gmail.com, nsaenzjulienne@suse.de, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org Subject: [PATCH 0/4] BCM2711's sdhci-iproc CMD timeouts Date: Mon, 22 Mar 2021 19:58:13 +0100 Message-Id: <20210322185816.27582-1-nsaenz@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This series tries to address rather odd behavior from BCM2711's integration of sdhci-iproc (Raspberry Pi 4's SoC). The controller will timeout on SDHCI CMDs under the following conditions: - No SD card plugged in (the card polling thread is running, CD irq disabled). - BCM2711's VPU clock configured at 500MHz or more, lower clocks are OK. There is no specific command that will time out, it seems random. I found out that by bumping the controller's frequency to 150MHz the issue disapears. So let's do that. Regards, Nicolas --- Nicolas Saenz Julienne (4): dt-bindings: mmc: iproc-sdhci: Convert to json-schema dt-bindings: mmc: iproc-sdhci: Add clock-frequency support mmc: sdhci-iproc: Set clock frequency as per DT ARM: dts: Fix-up EMMC2 controller's frequency .../bindings/mmc/brcm,iproc-sdhci.yaml | 64 +++++++++++++++++++ .../bindings/mmc/brcm,sdhci-iproc.txt | 37 ----------- arch/arm/boot/dts/bcm2711-rpi-4-b.dts | 6 ++ drivers/mmc/host/sdhci-iproc.c | 10 +++ 4 files changed, 80 insertions(+), 37 deletions(-) create mode 100644 Documentation/devicetree/bindings/mmc/brcm,iproc-sdhci.yaml delete mode 100644 Documentation/devicetree/bindings/mmc/brcm,sdhci-iproc.txt -- 2.30.2