Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <959e827d3407bfee9a367d8a68aa9aed184ddcf5.camel@gmail.com>
Subject: Re: [PATCH] thermal/core: avoid memory leak
From:   Muhammad Usama Anjum <musamaanjum@gmail.com>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     Zhang Rui <rui.zhang@intel.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Amit Kucheria <amitk@kernel.org>, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        colin.king@canonical.com
Date:   Tue, 23 Mar 2021 00:19:50 +0500
In-Reply-To: <20210322191817.GG1717@kadam>
References: <20210322191204.GA2122573@LEGION> <20210322191817.GG1717@kadam>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.4-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-03-22 at 22:18 +0300, Dan Carpenter wrote:
> On Tue, Mar 23, 2021 at 12:12:04AM +0500, Muhammad Usama Anjum wrote:
> > When memory allocation for cdev is successful but ida_simple_get fails,
> > branch to out_kfree_cdev label happens and cdev isn't freed. There are
> > other some other branches in which the memory can leaked. Fix it by
> > freeing cdev.
> > 
> 
> The patch is correct, but Daniel already sent a fix for it.
> 
Got it. Thank you.

Thanks,
Usama
> regards,
> dan carpenter
>