Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3691478pxf; Mon, 22 Mar 2021 12:32:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx4361RiH6V/wR0ntsumxst0EWnff7c8zbhjr1ZbjQnssWopwPkjzpZSFHZ0br946uQNfmn X-Received: by 2002:a17:906:aada:: with SMTP id kt26mr1303100ejb.137.1616441546595; Mon, 22 Mar 2021 12:32:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616441546; cv=none; d=google.com; s=arc-20160816; b=CyjEw7/tURaGemWdPUc+zeakkZWBm4+28VL45H5cPeCB1UW8kEZqJEZ8Wko2etY1On syqutlRUHDX4Qk3Ty6YVCB1HhSl2Fz6ROLAp0ukhJ60pcjzOWY+jKTipaPCQpkMqWXfM yKyEnpiFA9TLzw/5mz0WBjA2ilk2GxoEPXBJMcu5un9ZLMrYUCUR9MtGqHJzX/R1oI5+ qctbD4179hrZciQSUZDgpE6wM8Vj/dn9tjW/pb4Ll8mhhoBpX7nJXHhX5TJsJ8Zkjue+ 25UWjesmX9b4bUGjV9YAX9c9OL3+WfzASSe3GEhkVsCy1BCTMOMOkIQUoZchWOSkKDsW YFCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=Q7nFxv7hPI1y2kVzGZuD75PBIwupjqNvWglIYvHIW7s=; b=zu7/5YVCrIUBwSQfPrtACgRndE90o7IELYxDg1sTfGkb1ztpzluYiI6SCbIiuhpQ3x 8vID5ypui9vJwEIm/WK2OVY6SGLsTq3DmeR3cUIdp88uxaQHlGNl2bfst979Bg0OPRVI d16bT8EVvXpAf41md3VfUcGgACE/S8bShE/s5GQskveV87mV7X4PIm6DTeYhcs27tnp2 IiK/MEByYNO09yjk231LVzOYAHymd3B6tRjRE+DSDsDf6KW1sTHVTtEGas69L216AzvM A6Z89Yp7+/rAY4WjmU4oc55KA4sfwR26NmjGSJTGAf3WZRBf8BuPi9UMEIwlBwHFEGnX 37uQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=W+fiEgm4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j19si12233188ejs.516.2021.03.22.12.32.02; Mon, 22 Mar 2021 12:32:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2020-01-29 header.b=W+fiEgm4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230091AbhCVTaD (ORCPT + 99 others); Mon, 22 Mar 2021 15:30:03 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:53422 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231502AbhCVT36 (ORCPT ); Mon, 22 Mar 2021 15:29:58 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12MJONRw121388; Mon, 22 Mar 2021 19:29:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=Q7nFxv7hPI1y2kVzGZuD75PBIwupjqNvWglIYvHIW7s=; b=W+fiEgm4hAFRjWb+GwXASB5VBc9HRt1iwKP1uwPcoaXJNdHzEPbQhNcgUtFbELXjjg2q eqWaPgzhvC1qgnQByxCYQLEs+013MIRziFxKnq6SduwiwZI9bEeDF1y57ZgZDtw0QEeX jYA+4P3+hdLuVaUrVzha2/x7PDl8430H3LXyObhw2MAlqogYjfZlNySb5N7b5wjtOqTZ 8HqDzXqi4pVDfs5xuithMKBoRqEjJElnSKxsYND94kyXSIcATmMvatnkF8zKeHB8mzzf wPqfvnOWyBiyO8aJGm8wcLly4wUCBm00Xvx3ZEeUWswGX6kaaQiK1G1/Nh9vuMTRwCyV 1Q== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2130.oracle.com with ESMTP id 37d6jbcrag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Mar 2021 19:29:39 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 12MJK684048179; Mon, 22 Mar 2021 19:29:37 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 37dttr00kd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 22 Mar 2021 19:29:37 +0000 Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 12MJTZj3021739; Mon, 22 Mar 2021 19:29:35 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 22 Mar 2021 12:29:34 -0700 Date: Mon, 22 Mar 2021 22:29:27 +0300 From: Dan Carpenter To: Fabio Aiuto Cc: gregkh@linuxfoundation.org, joe@perches.com, apw@canonical.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/11] staging: rtl8723bs: moved function prototypes out of core/rtw_efuse.c Message-ID: <20210322192927.GH1717@kadam> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-IMR: 1 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9931 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0 spamscore=0 mlxscore=0 phishscore=0 suspectscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103220141 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=9931 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1011 priorityscore=1501 spamscore=0 adultscore=0 impostorscore=0 mlxlogscore=999 mlxscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2103220141 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2021 at 03:31:40PM +0100, Fabio Aiuto wrote: > fix the following checkpatch issues: > > WARNING: externs should be avoided in .c files > 35: FILE: drivers/staging/rtl8723bs/core/rtw_efuse.c:35: > +bool > > moved two function prototypes in include/rtw_efuse.h Can't you just make these functions static instead? regards, dan carpenter