Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422708AbWJFQnp (ORCPT ); Fri, 6 Oct 2006 12:43:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422710AbWJFQnp (ORCPT ); Fri, 6 Oct 2006 12:43:45 -0400 Received: from smtp.osdl.org ([65.172.181.4]:492 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1422703AbWJFQnn (ORCPT ); Fri, 6 Oct 2006 12:43:43 -0400 Date: Fri, 6 Oct 2006 09:40:24 -0700 (PDT) From: Linus Torvalds To: Dmitry Torokhov cc: Jeff Garzik , David Howells , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, Ingo Molnar , Alan Cox , Andrew Morton , Thomas Gleixner , Greg KH , David Brownell , Alan Stern Subject: Re: [PATCH, RAW] IRQ: Maintain irq number globally rather than passing to IRQ handlers In-Reply-To: Message-ID: References: <20061002132116.2663d7a3.akpm@osdl.org> <20061002162053.17763.26032.stgit@warthog.cambridge.redhat.com> <18975.1160058127@warthog.cambridge.redhat.com> <4525A8D8.9050504@garzik.org> <1160133932.1607.68.camel@localhost.localdomain> <45263ABC.4050604@garzik.org> <20061006111156.GA19678@elte.hu> <45263D9C.9030200@garzik.org> <452673AC.1080602@garzik.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1030 Lines: 29 On Fri, 6 Oct 2006, Dmitry Torokhov wrote: > > But drivers rarely care about exact IRQ that caused their interrupt > routines to be called. Sure. But it's not a _cleanup_ as far as I can tell. > Drivers that truly need to know IRQ can have it added to dev_id cookie > and use separate dev_ids. I'm not saying that what you describe is impossible. I'm just saying that it's pointless. What's wrong with passing in "irq"? It makes sense from a logical angle, and it's something you kind of expect if you think of irq's as "signals for the kernel" (which they almost literally used to be, why do you think it was called "SA_SHIRQ" etc?). So there is absolutely nothing wrong with passing in irq from a conceptual or a practical angle, and some routines _do_ use it. Linus - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/