Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Khalil Blaiech <kblaiech@nvidia.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Wolfram Sang <wsa@kernel.org>,
        Loic Poulain <loic.poulain@linaro.org>,
        "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
CC:     Robert Foss <robert.foss@linaro.org>,
        Wolfram Sang <wsa@the-dreams.de>
Subject: RE: [PATCH v1 1/1] i2c: drivers: Use generic definitions for bus
 frequencies (part 2)
Thread-Topic: [PATCH v1 1/1] i2c: drivers: Use generic definitions for bus
 frequencies (part 2)
Thread-Index: AQHXHzv5BmB2lqJv0Eas3SF/QSU/B6qQoNyA
Date:   Mon, 22 Mar 2021 23:05:46 +0000
Message-ID: <MN2PR12MB3616832982345406F6289CB4AB659@MN2PR12MB3616.namprd12.prod.outlook.com>
References: <20210322165405.44980-1-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20210322165405.44980-1-andriy.shevchenko@linux.intel.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 77283a95-7f96-44ed-06d5-08d8ed870734
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2021 23:05:46.9073
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Xfv+NRYnxTxGEbQ6L03nDP/HxuLJqyWUPt5KR9SMKHvT5aeoLn+LjQ7nhD3mxH3/nctg4BZDra6RN95xjk97rQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB2973
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Thanks.
Acked-by: Khalil Blaiech <kblaiech@nvidia.com>

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Sent: Monday, March 22, 2021 12:54 PM
> To: Wolfram Sang <wsa@kernel.org>; Khalil Blaiech <kblaiech@nvidia.com>;
> Loic Poulain <loic.poulain@linaro.org>; linux-i2c@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-arm-msm@vger.kernel.org
> Cc: Robert Foss <robert.foss@linaro.org>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>; Wolfram Sang <wsa@the-
> dreams.de>
> Subject: [PATCH v1 1/1] i2c: drivers: Use generic definitions for bus
> frequencies (part 2)
>=20
> Since we have generic definitions for bus frequencies, let's use them.
>=20
> Cc: Wolfram Sang <wsa@the-dreams.de>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/i2c/busses/i2c-mlxbf.c    | 14 ++++----------
>  drivers/i2c/busses/i2c-qcom-cci.c |  4 ++--
>  2 files changed, 6 insertions(+), 12 deletions(-)
>=20
> diff --git a/drivers/i2c/busses/i2c-mlxbf.c b/drivers/i2c/busses/i2c-mlxb=
f.c
> index 2fb0532d8a16..80ab831df349 100644
> --- a/drivers/i2c/busses/i2c-mlxbf.c
> +++ b/drivers/i2c/busses/i2c-mlxbf.c
> @@ -172,12 +172,6 @@
>  #define MLXBF_I2C_SMBUS_THIGH_MAX_TBUF            0x14
>  #define MLXBF_I2C_SMBUS_SCL_LOW_TIMEOUT           0x18
>=20
> -enum {
> -	MLXBF_I2C_TIMING_100KHZ =3D 100000,
> -	MLXBF_I2C_TIMING_400KHZ =3D 400000,
> -	MLXBF_I2C_TIMING_1000KHZ =3D 1000000,
> -};
> -
>  /*
>   * Defines SMBus operating frequency and core clock frequency.
>   * According to ADB files, default values are compliant to 100KHz SMBus
> @@ -1202,7 +1196,7 @@ static int mlxbf_i2c_init_timings(struct
> platform_device *pdev,
>=20
>  	ret =3D device_property_read_u32(dev, "clock-frequency",
> &config_khz);
>  	if (ret < 0)
> -		config_khz =3D MLXBF_I2C_TIMING_100KHZ;
> +		config_khz =3D I2C_MAX_STANDARD_MODE_FREQ;
>=20
>  	switch (config_khz) {
>  	default:
> @@ -1210,15 +1204,15 @@ static int mlxbf_i2c_init_timings(struct
> platform_device *pdev,
>  		pr_warn("Illegal value %d: defaulting to 100 KHz\n",
>  			config_khz);
>  		fallthrough;
> -	case MLXBF_I2C_TIMING_100KHZ:
> +	case I2C_MAX_STANDARD_MODE_FREQ:
>  		config_idx =3D MLXBF_I2C_TIMING_CONFIG_100KHZ;
>  		break;
>=20
> -	case MLXBF_I2C_TIMING_400KHZ:
> +	case I2C_MAX_FAST_MODE_FREQ:
>  		config_idx =3D MLXBF_I2C_TIMING_CONFIG_400KHZ;
>  		break;
>=20
> -	case MLXBF_I2C_TIMING_1000KHZ:
> +	case I2C_MAX_FAST_MODE_PLUS_FREQ:
>  		config_idx =3D MLXBF_I2C_TIMING_CONFIG_1000KHZ;
>  		break;
>  	}
> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-q=
com-
> cci.c
> index 1c259b5188de..c63d5545fc2a 100644
> --- a/drivers/i2c/busses/i2c-qcom-cci.c
> +++ b/drivers/i2c/busses/i2c-qcom-cci.c
> @@ -569,9 +569,9 @@ static int cci_probe(struct platform_device *pdev)
>  		cci->master[idx].mode =3D I2C_MODE_STANDARD;
>  		ret =3D of_property_read_u32(child, "clock-frequency", &val);
>  		if (!ret) {
> -			if (val =3D=3D 400000)
> +			if (val =3D=3D I2C_MAX_FAST_MODE_FREQ)
>  				cci->master[idx].mode =3D I2C_MODE_FAST;
> -			else if (val =3D=3D 1000000)
> +			else if (val =3D=3D I2C_MAX_FAST_MODE_PLUS_FREQ)
>  				cci->master[idx].mode =3D
> I2C_MODE_FAST_PLUS;
>  		}
>=20
> --
> 2.30.2