Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   "Namjae Jeon" <namjae.jeon@samsung.com>
To:     "'Christoph Hellwig'" <hch@lst.de>
Cc:     <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-cifs@vger.kernel.org>,
        <linux-cifsd-devel@lists.sourceforge.net>, <smfrench@gmail.com>,
        <senozhatsky@chromium.org>, <hyc.lee@gmail.com>,
        <viro@zeniv.linux.org.uk>, <hch@infradead.org>,
        <ronniesahlberg@gmail.com>, <aurelien.aptel@gmail.com>,
        <aaptel@suse.com>, <sandeen@sandeen.net>,
        <colin.king@canonical.com>, <rdunlap@infradead.org>,
        "'Sergey Senozhatsky'" <sergey.senozhatsky@gmail.com>,
        "'Steve French'" <stfrench@microsoft.com>,
        "'Dan Carpenter'" <dan.carpenter@oracle.com>
In-Reply-To: <20210322065011.GA2909@lst.de>
Subject: RE: [PATCH 2/5] cifsd: add server-side procedures for SMB3
Date:   Tue, 23 Mar 2021 08:20:00 +0900
Message-ID: <009c01d71f71$e1a5e470$a4f1ad50$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Thread-Index: AQGKnGOaYF8FWW41Vo1OapoCvoUV0QJx6VhoAkDjIaQCMP/z3QDRv4r9quv+OfA=
Content-Language: ko
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20210322051344.1706-1-namjae.jeon@samsung.com>
        <CGME20210322052206epcas1p438f15851216f07540537c5547a0a2c02@epcas1p4.samsung.com>
        <20210322051344.1706-3-namjae.jeon@samsung.com>
        <20210322064712.GD1667@kadam> <20210322065011.GA2909@lst.de>
Precedence: bulk


> On Mon, Mar 22, 2021 at 09:47:13AM +0300, Dan Carpenter wrote:
> > On Mon, Mar 22, 2021 at 02:13:41PM +0900, Namjae Jeon wrote:
> > > +static unsigned char
> > > +asn1_octet_decode(struct asn1_ctx *ctx, unsigned char *ch) {
> > > +	if (ctx->pointer >= ctx->end) {
> > > +		ctx->error = ASN1_ERR_DEC_EMPTY;
> > > +		return 0;
> > > +	}
> > > +	*ch = *(ctx->pointer)++;
> > > +	return 1;
> > > +}
> >
> >
> > Make this bool.
> >
> 
> More importantly don't add another ANS1 parser, but use the generic one in lib/asn1_decoder.c instead.
> CIFS should also really use it.
Okay, Let me check it, cifs also...
Thanks!