Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3896735pxf; Mon, 22 Mar 2021 19:16:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxTpqpqVN9ne+WYJEG4FqmhfEbHGh6SE+/rfaiY+H5qFtnvl8/i+UvazM4Cp2t4uC2wnfdo X-Received: by 2002:a17:907:9808:: with SMTP id ji8mr2588402ejc.333.1616465771905; Mon, 22 Mar 2021 19:16:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616465771; cv=none; d=google.com; s=arc-20160816; b=KbZ65PKbiMCOtGrGwr4R3bwjVZ/xJIECB5sE+ZwGtUMPlTHaWVd7TgAEyPcbWF1UYI dcK54B1FcbAAy4YFEcpCBSWZcQqGIf2Usk4Dj0BhYf4AS8gM8QGBSY04xjrJjldjG6Rx tQ8AsVj3xIYTx/ZtgMEOjic7xBRTUIWU32lYj+jsB3vOOWhpHdzQ0CuZVOZ78EGTF0Nr zURc8OXpzpGaPgbMUCcFnZPOjeQUbZP3Ck3zmVG/p7QAa4vvSvZYcrIGNoy1qCV4YAC/ /7ZPjym2XsdDruDEK1HZNZm2E4JU69rhuYMCVLVAfBErBEbdecUEO6oPnDnht1en2J8+ myeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:sender:dkim-signature; bh=BhScQ3yWiLFHObXc+RqfiRxbs75wFh3XbDpgxT9XN6A=; b=OA0bXwOgTHaqZrsf+XZyAkyo38XQvVbg+lI1Wnkp4S47uGe15xzRL6WwBzzYxONn1a p3OMtwo09w8x6Mlpdkkj1MiCXxCmJyATtaeaCMyKa+kX19geHVD6K2WM+euD2igU58nA NtKRta5FkfG4x/bmpryhlalBH084qYsMC51thawUd9OlVwpsyUvssIWZz/9P8/C++PuN 9pmS/GTfsmj5ZF6oqoMLErasDwaVa9MDhdkLwk2fWZ0s2fy4tdw5iVeqWosj6zkOpjaq MvQgas7vMIREST/0b08zl0VkK8V/GvJTjuaJYfjQByrEwLdhGfAPOwiH3niTbtNR2kUb P5qg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="mskdFPY/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id t8si12492175edw.476.2021.03.22.19.15.48; Mon, 22 Mar 2021 19:16:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="mskdFPY/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229986AbhCWCOw (ORCPT + 99 others); Mon, 22 Mar 2021 22:14:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229547AbhCWCOk (ORCPT ); Mon, 22 Mar 2021 22:14:40 -0400 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5F08C061574; Mon, 22 Mar 2021 19:14:28 -0700 (PDT) Received: by mail-oi1-x22c.google.com with SMTP id l79so15373177oib.1; Mon, 22 Mar 2021 19:14:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BhScQ3yWiLFHObXc+RqfiRxbs75wFh3XbDpgxT9XN6A=; b=mskdFPY/EU3mbsQ6d2Vdkxg9XMruXSQqOv10G0o7OQYT3cqWSyMwWYGBjXQNEUZ4ua YNVPbYVkpqJTx2pmWuUtVoNxcfUAPEWWQKNTgsX/iMf8nTWQH1alGtt6EmCJRAozTfqc N4XSNxzr1NsNEQ57SwcTFXSG05AGthMQDU96tLodYDr2laPzAlyq6MhB4BmoNAAatqEK B+3mqrPQPTAyVCRqAW7217fxnZfZcJysbfpN0NKhbs3LzS2U9918BbvCqkfkcYrhopxO qY9zr4NYjV2e+yCT9rbMmbyoq8AFjVfQSD6AwQenGOtdnM+i6iMmMZH+PNRFd2pXJGSu Dvaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=BhScQ3yWiLFHObXc+RqfiRxbs75wFh3XbDpgxT9XN6A=; b=iLak0wTRP7fV3TBo/w26BGSwTrjgsJFmRyCWwUf0xwG9yxAnWKOAxpWYSwRLyKgE/V ttZSuZ4Bc2aJZJHfqrHl15zt5HQu875KxKWDjH+43mQu2wcSZgoooxAaiJIVkDoEH0/B aIGRj2V8ndQjbCPo5Xexl/PdGIF+jY35hpprN5+AMb6rnW5K4VWh7kcfaKIRwOgL5kn0 dnSdcfzfYICmNy/z0a1NWIhD8pUvbvaR4CueS6Tlm0i/8dWXCqG8FwFUBg5UY4Ayqp1j BNHSNCPU5Ml3nSr/nHB3QiKH3/3+ltTlXpgVkRmV8D0XKjeEEllfPxQMXFdceZjjfaGY HQPw== X-Gm-Message-State: AOAM533kLWUpUvZsx6Ps5J9f3KldEmf45IyhoP/qvFXim3QrMV3Hr5lx anyXvJklKFV2N3pS4VtmfuE= X-Received: by 2002:a05:6808:b3b:: with SMTP id t27mr1528092oij.131.1616465668090; Mon, 22 Mar 2021 19:14:28 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id t14sm3609395otj.50.2021.03.22.19.14.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Mar 2021 19:14:27 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [PATCH] drivers: watchdog: Remove duplicate include of kernel.h To: Wan Jiabing , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Cc: kael_w@yeah.net References: <20210323014320.136473-1-wanjiabing@vivo.com> From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAlVcphcFCRmg06EACgkQyx8mb86fmYFg0RAA nzXJzuPkLJaOmSIzPAqqnutACchT/meCOgMEpS5oLf6xn5ySZkl23OxuhpMZTVX+49c9pvBx hpvl5bCWFu5qC1jC2eWRYU+aZZE4sxMaAGeWenQJsiG9lP8wkfCJP3ockNu0ZXXAXwIbY1O1 c+l11zQkZw89zNgWgKobKzrDMBFOYtAh0pAInZ9TSn7oA4Ctejouo5wUugmk8MrDtUVXmEA9 7f9fgKYSwl/H7dfKKsS1bDOpyJlqhEAH94BHJdK/b1tzwJCFAXFhMlmlbYEk8kWjcxQgDWMu GAthQzSuAyhqyZwFcOlMCNbAcTSQawSo3B9yM9mHJne5RrAbVz4TWLnEaX8gA5xK3uCNCeyI sqYuzA4OzcMwnnTASvzsGZoYHTFP3DQwf2nzxD6yBGCfwNGIYfS0i8YN8XcBgEcDFMWpOQhT Pu3HeztMnF3HXrc0t7e5rDW9zCh3k2PA6D2NV4fews9KDFhLlTfCVzf0PS1dRVVWM+4jVl6l HRIAgWp+2/f8dx5vPc4Ycp4IsZN0l1h9uT7qm1KTwz+sSl1zOqKD/BpfGNZfLRRxrXthvvY8 BltcuZ4+PGFTcRkMytUbMDFMF9Cjd2W9dXD35PEtvj8wnEyzIos8bbgtLrGTv/SYhmPpahJA l8hPhYvmAvpOmusUUyB30StsHIU2LLccUPPOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAlVcpi8FCRmg08MACgkQyx8mb86fmYHNRQ/+ J0OZsBYP4leJvQF8lx9zif+v4ZY/6C9tTcUv/KNAE5leyrD4IKbnV4PnbrVhjq861it/zRQW cFpWQszZyWRwNPWUUz7ejmm9lAwPbr8xWT4qMSA43VKQ7ZCeTQJ4TC8kjqtcbw41SjkjrcTG wF52zFO4bOWyovVAPncvV9eGA/vtnd3xEZXQiSt91kBSqK28yjxAqK/c3G6i7IX2rg6pzgqh hiH3/1qM2M/LSuqAv0Rwrt/k+pZXE+B4Ud42hwmMr0TfhNxG+X7YKvjKC+SjPjqp0CaztQ0H nsDLSLElVROxCd9m8CAUuHplgmR3seYCOrT4jriMFBtKNPtj2EE4DNV4s7k0Zy+6iRQ8G8ng QjsSqYJx8iAR8JRB7Gm2rQOMv8lSRdjva++GT0VLXtHULdlzg8VjDnFZ3lfz5PWEOeIMk7Rj trjv82EZtrhLuLjHRCaG50OOm0hwPSk1J64R8O3HjSLdertmw7eyAYOo4RuWJguYMg5DRnBk WkRwrSuCn7UG+qVWZeKEsFKFOkynOs3pVbcbq1pxbhk3TRWCGRU5JolI4ohy/7JV1TVbjiDI HP/aVnm6NC8of26P40Pg8EdAhajZnHHjA7FrJXsy3cyIGqvg9os4rNkUWmrCfLLsZDHD8FnU mDW4+i+XlNFUPUYMrIKi9joBhu18ssf5i5Q= Message-ID: Date: Mon, 22 Mar 2021 19:14:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210323014320.136473-1-wanjiabing@vivo.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/22/21 6:43 PM, Wan Jiabing wrote: > linux/kernel.h has been included at line 17, so remove the > duplicate one at line 22. > > Signed-off-by: Wan Jiabing > --- > drivers/watchdog/dw_wdt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/watchdog/dw_wdt.c b/drivers/watchdog/dw_wdt.c > index 32d0e1781e63..b1642e2d9175 100644 > --- a/drivers/watchdog/dw_wdt.c > +++ b/drivers/watchdog/dw_wdt.c > @@ -19,7 +19,6 @@ > #include > #include > #include > -#include > #include > #include > #include > The reason for the duplicate include is the non-alphabetic order of include files. I find that worse than the duplicate include. If it is too much effort to reorder include files to be in alphabetic order, please at least don't make it worse and remove the other include. Guenter