Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp3910074pxf; Mon, 22 Mar 2021 19:50:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxu+kLceXtxCmCv0B+GLs1Yvjh5ThVYlM/dF1mTVQVC2AN1N9klMbO/SUHzCuQB3EYshlms X-Received: by 2002:a17:907:1c1e:: with SMTP id nc30mr2784411ejc.34.1616467835033; Mon, 22 Mar 2021 19:50:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616467835; cv=none; d=google.com; s=arc-20160816; b=O2HQugdJ3g2R33urjSj5pDtvRiIXYYloWKXyVCXjal51pQz6YvkToGNplZMIFaAFUC dj3EFIrlxNb4v3EzQnxLsRvY6OJZrIQB/NeZkCdhwRPB5emb2S5HgSXlw3LKfgVkybD1 WmyRShEn1CZmuHSJk0tHwK5sFPRneNJvzi9StazWEjLzh9yqLv/g/tuhsVB8FpWxkWme ghKUnyq89z5eRElOo0z2Dwn1B+TJMMiycgZA8x/b4WQCPmnPMjREIq0RAX4WEJo+abZs EGgp4nj9+V4BduEvGWuFZ9r+/gmUnKyUKPkPH3uh4afsTKkQKLoqFmCF+AKAwMcaaVCn 8dUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=YbEftA0u+UYFfOktI+XrK092nwQY5PEYPai7N449i4Q=; b=gLYx38cmMSS4wrmpjo7/a9aHVRvETM27tkoO7aBxGb1QH1i9xw0DlP/QCyRIiLbcej La5pCznPlGSkimp5nA/Oxu/vABlOJYUMCqW0eR6RoHDZRxeu1Km52LbDwxvxEOILGcAM ZSnlGnzrByfmV10+Muk2q0pMPLGhs8a3/RBkaLxtO1nY3ybivgImziTO32cXutSjirQY ja3lV2iA23KHOiB10corR3KUGDNxct07+fKAW6rBe0HFSB3KwC5BqMDkr0/snYx7HLVU dPXrXdFjJ7qaqRSWVPPZ0VsKzBPKf+OgXCsYjsp+kgYfVewp+3iHoHiVLAIkgsV/wr9E +flw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bl1si2444291ejb.408.2021.03.22.19.50.12; Mon, 22 Mar 2021 19:50:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229994AbhCWCqv (ORCPT + 99 others); Mon, 22 Mar 2021 22:46:51 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:58505 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229760AbhCWCqX (ORCPT ); Mon, 22 Mar 2021 22:46:23 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=13;SR=0;TI=SMTPD_---0UT1Ea9s_1616467574; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UT1Ea9s_1616467574) by smtp.aliyun-inc.com(127.0.0.1); Tue, 23 Mar 2021 10:46:19 +0800 From: Jiapeng Chong To: l.stach@pengutronix.de Cc: linux+etnaviv@armlinux.org.uk, christian.gmeiner@gmail.com, airlied@linux.ie, daniel@ffwll.ch, sumit.semwal@linaro.org, christian.koenig@amd.com, etnaviv@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Jiapeng Chong Subject: [PATCH] drm/etnaviv: Remove redundant NULL check Date: Tue, 23 Mar 2021 10:46:12 +0800 Message-Id: <1616467572-112804-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:622:2-8: WARNING: NULL check before some freeing functions is not needed. ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:618:2-8: WARNING: NULL check before some freeing functions is not needed. ./drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:616:2-8: WARNING: NULL check before some freeing functions is not needed. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c index d05c359..bd0d66e 100644 --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c @@ -612,14 +612,10 @@ int etnaviv_ioctl_gem_submit(struct drm_device *dev, void *data, err_submit_cmds: if (ret && (out_fence_fd >= 0)) put_unused_fd(out_fence_fd); - if (stream) - kvfree(stream); - if (bos) - kvfree(bos); - if (relocs) - kvfree(relocs); - if (pmrs) - kvfree(pmrs); + kvfree(stream); + kvfree(bos); + kvfree(relocs); + kvfree(pmrs); return ret; } -- 1.8.3.1