Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 23 Mar 2021 03:12:42 +0000
From:   Matthew Wilcox <willy@infradead.org>
To:     Namjae Jeon <namjae.jeon@samsung.com>
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-cifs@vger.kernel.org,
        linux-cifsd-devel@lists.sourceforge.net, smfrench@gmail.com,
        senozhatsky@chromium.org, hyc.lee@gmail.com,
        viro@zeniv.linux.org.uk, hch@lst.de, hch@infradead.org,
        ronniesahlberg@gmail.com, aurelien.aptel@gmail.com,
        aaptel@suse.com, sandeen@sandeen.net, dan.carpenter@oracle.com,
        colin.king@canonical.com, rdunlap@infradead.org,
        'Sergey Senozhatsky' <sergey.senozhatsky@gmail.com>,
        'Steve French' <stfrench@microsoft.com>
Subject: Re: [PATCH 1/5] cifsd: add server handler and tranport layers
Message-ID: <20210323031242.GA1719932@casper.infradead.org>
References: <20210322051344.1706-1-namjae.jeon@samsung.com>
 <CGME20210322052204epcas1p1382cadbfe958d156c0ad9f7fcb8532b7@epcas1p1.samsung.com>
 <20210322051344.1706-2-namjae.jeon@samsung.com>
 <20210322221816.GW1719932@casper.infradead.org>
 <00d901d71f90$cdfd24f0$69f76ed0$@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <00d901d71f90$cdfd24f0$69f76ed0$@samsung.com>
Precedence: bulk

On Tue, Mar 23, 2021 at 12:01:22PM +0900, Namjae Jeon wrote:
> > On Mon, Mar 22, 2021 at 02:13:40PM +0900, Namjae Jeon wrote:
> > > +#define RESPONSE_BUF(w)		((void *)(w)->response_buf)
> > > +#define REQUEST_BUF(w)		((void *)(w)->request_buf)
> > 
> > Why do you do this obfuscation?
> I don't remember exactly, but back then, It looked easier...
> > 
> > > +#define RESPONSE_BUF_NEXT(w)	\
> > > +	((void *)((w)->response_buf + (w)->next_smb2_rsp_hdr_off))
> > > +#define REQUEST_BUF_NEXT(w)	\
> > > +	((void *)((w)->request_buf + (w)->next_smb2_rcv_hdr_off))
> > 
> > These obfuscations aren't even used; delete them
> They are used in many place.

Oh, argh.  patch 2/5 was too big, so it didn't make it into the mailing
list archive I was using to try to review this series.  Please break it
up into smaller pieces for next time!