Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Subject: RE: Re: [PATCH v31 2/4] scsi: ufs: L2P map management for HPB read
Reply-To: daejun7.park@samsung.com
Sender: Daejun Park <daejun7.park@samsung.com>
From:   Daejun Park <daejun7.park@samsung.com>
To:     Can Guo <cang@codeaurora.org>, Bean Huo <huobean@gmail.com>
CC:     Daejun Park <daejun7.park@samsung.com>,
        Greg KH <gregkh@linuxfoundation.org>,
        "avri.altman@wdc.com" <avri.altman@wdc.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "asutoshd@codeaurora.org" <asutoshd@codeaurora.org>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        ALIM AKHTAR <alim.akhtar@samsung.com>,
        JinHwan Park <jh.i.park@samsung.com>,
        Javier Gonzalez <javier.gonz@samsung.com>,
        Sung-Jun Park <sungjun07.park@samsung.com>,
        Jinyoung CHOI <j-young.choi@samsung.com>,
        Dukhyun Kwon <d_hyun.kwon@samsung.com>,
        Keoseong Park <keosung.park@samsung.com>,
        Jaemyung Lee <jaemyung.lee@samsung.com>,
        Jieon Seol <jieon.seol@samsung.com>
In-Reply-To: <e9b912bca9fd48c9b2fd76bea80439ae@codeaurora.org>
Message-ID: <20210323053731epcms2p70788f357b546e9ca21248175a8884554@epcms2p7>
Date:   Tue, 23 Mar 2021 14:37:31 +0900
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 102P
DLP-Filter: Pass
References: <e9b912bca9fd48c9b2fd76bea80439ae@codeaurora.org>
        <20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p5>
        <20210322065410epcms2p431f73262f508e9e3e16bd4995db56a4b@epcms2p4>
        <75df140d2167eadf1089d014f571d711a9aeb6a5.camel@gmail.com>
        <d6a032261a642a4afed80188ea4772ee@codeaurora.org>
        <CGME20210322065127epcms2p5021a61416a6b427c62fcaf5d8b660860@epcms2p7>
Precedence: bulk

>On 2021-03-23 12:22, Can Guo wrote:
>> On 2021-03-22 17:11, Bean Huo wrote:
>>> On Mon, 2021-03-22 at 15:54 +0900, Daejun Park wrote:
>>>> +       switch (rsp_field->hpb_op) {
>>>> 
>>>> +       case HPB_RSP_REQ_REGION_UPDATE:
>>>> 
>>>> +               if (data_seg_len != DEV_DATA_SEG_LEN)
>>>> 
>>>> +                       dev_warn(&hpb->sdev_ufs_lu->sdev_dev,
>>>> 
>>>> +                                "%s: data seg length is not
>>>> same.\n",
>>>> 
>>>> +                                __func__);
>>>> 
>>>> +               ufshpb_rsp_req_region_update(hpb, rsp_field);
>>>> 
>>>> +               break;
>>>> 
>>>> +       case HPB_RSP_DEV_RESET:
>>>> 
>>>> +               dev_warn(&hpb->sdev_ufs_lu->sdev_dev,
>>>> 
>>>> +                        "UFS device lost HPB information during
>>>> PM.\n");
>>>> 
>>>> +               break;
>>> 
>>> Hi Deajun,
>>> This series looks good to me. Just here I have one question. You 
>>> didn't
>>> handle HPB_RSP_DEV_RESET, just a warning.  Based on your SS UFS, how 
>>> to
>>> handle HPB_RSP_DEV_RESET from the host side? Do you think we shoud
>>> reset host side HPB entry as well or what else?
>>> 
>>> 
>>> Bean
>> 
>> Same question here - I am still collecting feedbacks from flash vendors 
>> about
>> what is recommanded host behavior on reception of HPB Op code 0x2, 
>> since it
>> is not cleared defined in HPB2.0 specs.
>> 
>> Can Guo.
> 
>I think the question should be asked in the HPB2.0 patch, since in 
>HPB1.0 device
>control mode, a HPB reset in device side does not impact anything in 
>host side -
>host is not writing back any HPB entries to device anyways and HPB Read 
>cmd with
>invalid HPB entries shall be treated as normal Read(10) cmd without any 
>problems.

Yes, UFS device will process read command even the HPB entries are valid or
not. So it is warning about read performance drop by dev reset.

Thanks,
Daejun

>Please correct me if I am wrong.


>Thanks,
>Can Guo.
> 
> 
>