Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] mm: process_vm_access: Remove duplicate include of
 compat.h
To:     Wan Jiabing <wanjiabing@vivo.com>,
        Andrew Morton <akpm@linux-foundation.org>
CC:     <kael_w@yeah.net>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <20210323032322.262579-1-wanjiabing@vivo.com>
From:   Miaohe Lin <linmiaohe@huawei.com>
Message-ID: <a96d8bf1-292f-a239-fc31-1022c7c4a296@huawei.com>
Date:   Tue, 23 Mar 2021 14:33:14 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20210323032322.262579-1-wanjiabing@vivo.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2021/3/23 11:23, Wan Jiabing wrote:
> linux/compat.h has been included at line 8.So we remove 
> the duplicate one at line 12.
> 

line 12 one is added via eb351d75ce1e ("mm/process_vm_access.c: include compat.h") to fix the build error:
 mm/process_vm_access.c:277:5: error: implicit declaration of function 'in_compat_syscall'; did you mean 'in_ia32_syscall'? [-Werror=implicit-function-declaration]

There might be something wrong.

> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
>  mm/process_vm_access.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/mm/process_vm_access.c b/mm/process_vm_access.c
> index f5fee9cf90f8..4bcc11958089 100644
> --- a/mm/process_vm_access.c
> +++ b/mm/process_vm_access.c
> @@ -9,7 +9,6 @@
>  #include <linux/mm.h>
>  #include <linux/uio.h>
>  #include <linux/sched.h>
> -#include <linux/compat.h>
>  #include <linux/sched/mm.h>
>  #include <linux/highmem.h>
>  #include <linux/ptrace.h>
>