Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4035138pxf; Tue, 23 Mar 2021 00:23:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOX+luK0fJKIBpX+zCscsaLIr3HONd8ZQfNNWg4xM8gUaoV7w4W/IrXzgMRpl6zTVBwNpZ X-Received: by 2002:a50:f311:: with SMTP id p17mr3374596edm.188.1616484231302; Tue, 23 Mar 2021 00:23:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616484231; cv=none; d=google.com; s=arc-20160816; b=f7hGsE9XetxizijjBjQE9KBuI0WaaehIMk3gVs687CEqf63h16+u7oawnXs+2rYawO 1sHwRXGQ44LRWF5m0vi3YvhFm8NyGH4ps428gAneZh8qYsFsgFIlC4V6u7z6fYfO1igR +m7qPBZF3+rK47zx17Spgsr1sK/H9Ka2+diRaOe1d2H5mBln8JLD5QqcXJX9l0X/YeWp WdeNWrQ2lRY3B0IQ22nSKjk/vMedQQJxmCOFOdmIoltBr0GBYZWgFmx14DwQSmMFNdR/ 3q4K7UtUGn0Tc2CIzO/wprzCF3v4b7WjmO4wCwQ0w2rNz2C3rb0uXP3PQSScCgavt2uw KN0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=PAyK/33Yzrt2HbR7xcRnh2/xAS7yuYL0j4wdjMrYADc=; b=ikqQPhXqgfAkCyVFqnB5Hr0dqsXF7Oyj29Iu/HnXLWbm2JVX3Y3xdywPuWr4C8B4VH M2rgzBO27PxilXjK8w0m7sQnj7fbI6EpEEMZHZ6Mm8sokXj6qk+16tYHEiLsO27RDwS+ d6aFxuBkWMnodxVerE8ZeAgT4eAEQfxpCoErxWTaItituQqmJHZc4Xzh/DUHKjYXJUNE J1JCpIK51JtI3UgzbXYTkWI4jPjqflOg1VDUkaam4ZO5b6pdAPIuj4LLoe8uGwBZ7SnY WUP/LOIMFakrQSD0MxO8W3Zj6oYcaFiVvz5kdUQ4l2WDw+TFV6rqfpT9y8DLdWdestfQ MPnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0SLi843W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s1si12754172ejf.199.2021.03.23.00.23.28; Tue, 23 Mar 2021 00:23:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0SLi843W; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230108AbhCWHUa (ORCPT + 99 others); Tue, 23 Mar 2021 03:20:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:37796 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbhCWHUO (ORCPT ); Tue, 23 Mar 2021 03:20:14 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 86713619AB; Tue, 23 Mar 2021 07:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616484014; bh=xf/FJRT3op6/DF9iLA9eJZ5X6gvMzU0dp2gmxrew8Zw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0SLi843WFB3SJZg1fnvsZ7anQHXNe+tpuxQ/BMjEaOPoHHmBW0dcKdyzsuaC4pXqd luEzlgoRzJAgbshLSsQLvskuorTzaTRNSSeoCreTX+NTibG6CB12inl1cjD8JTYh4U yEgwJXtSt6KmGoREjyW3ICqqpWHnu+jo3mYDW3Us= Date: Tue, 23 Mar 2021 08:20:11 +0100 From: Greg KH To: Tom Lendacky Cc: Isaku Yamahata , linux-kernel@vger.kernel.org, stable@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, brijesh.singh@amd.com, tglx@linutronix.de, bp@alien8.de, isaku.yamahata@gmail.com, "Kirill A . Shutemov" Subject: Re: [PATCH] X86: __set_clr_pte_enc() miscalculates physical address Message-ID: References: <81abbae1657053eccc535c16151f63cd049dcb97.1616098294.git.isaku.yamahata@intel.com> <0d99865a-30d5-9857-1a53-cc26ada6608c@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0d99865a-30d5-9857-1a53-cc26ada6608c@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2021 at 04:02:11PM -0500, Tom Lendacky wrote: > On 3/18/21 3:26 PM, Isaku Yamahata wrote: > > __set_clr_pte_enc() miscalculates physical address to operate. > > pfn is in unit of PG_LEVEL_4K, not PGL_LEVEL_{2M, 1G}. > > Shift size to get physical address should be PAGE_SHIFT, > > not page_level_shift(). > > > > Fixes: dfaaec9033b8 ("x86: Add support for changing memory encryption attribute in early boot") > > Reviewed-by: Kirill A. Shutemov > > Signed-off-by: Isaku Yamahata > > Reviewed-by: Tom Lendacky This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.