Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4098827pxf; Tue, 23 Mar 2021 02:37:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJySjIz8COUK0ssXGHmeF5e4ux/40R3A2CKGl5k6cqGoAAyvgUQ5J+rUq2ct1Kw7YsI5TsZm X-Received: by 2002:a17:906:5d06:: with SMTP id g6mr4066259ejt.216.1616492265861; Tue, 23 Mar 2021 02:37:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616492265; cv=none; d=google.com; s=arc-20160816; b=Zpt7/S5luf6WVSoGcIV6wJSEINMP9xL+gdyks7YsBTThxG4X87Nlk0UHgAkhoF7r8V NexfZ/12MfjOXlmFw+MU/ij2qCPqFsNi+3ZyBjds9Vbr40S5szYDRfmTPwg5tnvOtd5D jNiK5jYthGSs/NId4Iwge6KzbNWOfnlfv1d++7uPHvGGqaYScFLPTpx1d9/fgy70vnSN ZXRlT+p7h4uPNp2NMMgEOWxxJXB3xvKTgGjqi0wIDpdo9cXP0EKtHKlFbGAZEfHKvC1g O4DCFUEZGMmLjHkduTPuS//X3AoDsPoS5wq9egnQl5av977T1/JMyBAFvYBHuEX6MYZc KHnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=T8ujadlsfMOs83cAs9UtDu2l6f6I0ppOLicLa7+9n6s=; b=xAF3Uk1u4ncwSW+XKJQhhrGcuDM1o02vzLbgfhi3E/cZcKyoRI/noB0If4b98OjQ7E uk8hy8B78D/2wdY8xHqgRSzE/xAMTBlvZcaTiF33paVRcOKEtSed40FCn5dzlHD5kLl8 tvtnjb+LulFHdbF9e9IhocQt2sKMApayJBxvIcHfJXAPxFg8DMtCR9jvU73yCZdzjmz1 NcksJNCtmPXBSMp/QOF023m12NfKZWOkQ/IfQ1nJ9EKDO0DO+8ee/0vJqYOE+88L9o40 h7XM8e4eGHb5fmlzKNE72xkIGFhr9SAxkffoaLJr0zoDU/IiQ7f9CuykWFSmkgjeV7HN TgsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rhGUZpU3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h9si13672021edv.190.2021.03.23.02.37.23; Tue, 23 Mar 2021 02:37:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rhGUZpU3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230139AbhCWJgI (ORCPT + 99 others); Tue, 23 Mar 2021 05:36:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41582 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230103AbhCWJfo (ORCPT ); Tue, 23 Mar 2021 05:35:44 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1555FC061763 for ; Tue, 23 Mar 2021 02:35:44 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id u9so25954285ejj.7 for ; Tue, 23 Mar 2021 02:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=T8ujadlsfMOs83cAs9UtDu2l6f6I0ppOLicLa7+9n6s=; b=rhGUZpU3lq5FuN30OA5Lu/hODznQG1MHp3rCnsMvUr+jaUOk5+8issQpgldBzkuSw9 i2fmo6f9WkqeLOhkE75LJsZtyjw4jy0BOeMgVvkPN/mQM7cm5q00oNKE19Q+Lfwf3hND d3Vyr2vaKckTtvJRZJagY+VMVZB220QmCBLiF1zJdopIMcih5ZmHvEr2Hic6fmNOmtJl YI5o5EuJYApg+IDqrgbWj/QogHm2uvark0SAUYZDxVJvfy4hhXJP3rg+Qg30zMFARi5s +McQ5ehedTb4vloDDhWhPsNV/y5IWPY5wkGxTNxserKwKfhgwYHJPf8bpefB68WXf4Lc G4Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=T8ujadlsfMOs83cAs9UtDu2l6f6I0ppOLicLa7+9n6s=; b=AzpsivuU+nodU1++O+p8Mxku4kLAx3WHfuAEYUIPX/NjwPIBRRZKNnJxllBKOd5Nc2 tPoEr3LKGJkeKlXaTAm9nCezyp1eCC6HALw2HiSzJYKRjgQJkRoQF0SL4VSeLq3Do947 oOZsa5MaME+op3GLsqAGsLQ20ezBPRrLhUAJ0J1QpZm/Cejvyp7zcnkeBjGmCfbIWOsX 0bZj5UGxvvCMmppkpV/WL8LJlMUDanX1DZvuVQ2ehfF1tWH304zbuNaPzMOFUngf/J7h RAF7GZH+4ergbah+VP8ce08QAW5tpn10Sc+iMSxpslFIrredexnZZ/6WfTORjbthGIN/ 7SyQ== X-Gm-Message-State: AOAM533zpidQXZy7/1XdBHh7PawYYCUb9FyWq8P5JB3R0EOVr8IRV64/ iucQ8Zov9MlOPJdZAPAP0KCR/A== X-Received: by 2002:a17:907:2809:: with SMTP id eb9mr3935111ejc.204.1616492142655; Tue, 23 Mar 2021 02:35:42 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id a9sm12701859eds.33.2021.03.23.02.35.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 02:35:42 -0700 (PDT) Date: Tue, 23 Mar 2021 09:35:40 +0000 From: Daniel Thompson To: Lee Jones Cc: Konrad Dybcio , phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, Jingoo Han , Pavel Machek , Dan Murphy , Rob Herring , Andy Gross , Bjorn Andersson , Kiran Gunda , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH 2/2] video: backlight: qcom-wled: Add PMI8994 compatible Message-ID: <20210323093540.dqrhjlvr6oza3hvt@maple.lan> References: <20210228124106.135812-1-konrad.dybcio@somainline.org> <20210228124106.135812-2-konrad.dybcio@somainline.org> <20210322161810.biagj2qro66rv4gt@maple.lan> <20210323083935.GF2916463@dell> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210323083935.GF2916463@dell> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 23, 2021 at 08:39:35AM +0000, Lee Jones wrote: > On Mon, 22 Mar 2021, Daniel Thompson wrote: > > > On Sun, Feb 28, 2021 at 01:41:05PM +0100, Konrad Dybcio wrote: > > > Add a compatible for PMI8994 WLED. It uses the V4 of WLED IP. > > > > > > Signed-off-by: Konrad Dybcio > > > > Reviewed-by: Daniel Thompson > > Why are you Reviewing/Acking a patch that was applied on the 10th? Simply an oversight. Looks like I forgot to remove it from my backlog when it was applied. Daniel. > > > > --- > > > drivers/video/backlight/qcom-wled.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/video/backlight/qcom-wled.c b/drivers/video/backlight/qcom-wled.c > > > index 3bc7800eb0a9..497b9035a908 100644 > > > --- a/drivers/video/backlight/qcom-wled.c > > > +++ b/drivers/video/backlight/qcom-wled.c > > > @@ -1704,6 +1704,7 @@ static int wled_remove(struct platform_device *pdev) > > > > > > static const struct of_device_id wled_match_table[] = { > > > { .compatible = "qcom,pm8941-wled", .data = (void *)3 }, > > > + { .compatible = "qcom,pmi8994-wled", .data = (void *)4 }, > > > { .compatible = "qcom,pmi8998-wled", .data = (void *)4 }, > > > { .compatible = "qcom,pm660l-wled", .data = (void *)4 }, > > > { .compatible = "qcom,pm8150l-wled", .data = (void *)5 }, > > -- > Lee Jones [李琼斯] > Senior Technical Lead - Developer Services > Linaro.org │ Open source software for Arm SoCs > Follow Linaro: Facebook | Twitter | Blog