Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4165082pxf; Tue, 23 Mar 2021 04:32:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwa36YCyeAQ0Sk4u0V1X6jfe26DuGKTYCNWVDK14O90r0hWQmIldgC4/jWkqPaD+QeJxVho X-Received: by 2002:a17:906:1b54:: with SMTP id p20mr4363967ejg.307.1616499128588; Tue, 23 Mar 2021 04:32:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616499128; cv=none; d=google.com; s=arc-20160816; b=Nfxy5o1WLfJiHBy8Wa4BaDOspR6DQ42A4WVspT/8S94u0Vr0nW6Hfzh80XoRfE/IzU f7A+T9R1wH7W8sFGlQfw5l5pWTsLkREJZzKhItnRxURZT/3ZywT+ihVVR0CUTwn8fgsX 0Un36WLB/tt/3+5THcNUjh7M8dURaWoEEzMpKCXZQsWgOfayA7pesS/7xSj7ikwbWvsz xmAj0KHSvJTKXV+D1uI0YoLVxVclRW2L5ZrBjFdSPfCIbbU4ayOsQMMie/b91hKv03DD N+NCEpzrF9YJKN6GArulNNGbbPQDHFC+PB97ZxdQmy/lrwHo7Hj22sCPbr5NgRZb+dKf sJ5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=NXH0z8liTO2LJq1cUKqd+Rn1KfTjWb3DfW9gVMvvJIE=; b=dtmu6uqpKhxsrbZyIc5i+NtNyCZe79dO3HuRVfB9qUztuNw1W8aGhQjZmzESpVq4N3 L99OfskeBViQ7g4BbWq7WH0vDEzJi+3WNbBdUS6H8iC7uIN/4IrVJMzIH0cptdry23Qd Z/XxujImKp666wBkoIia9FL0pJTkKexi+aCd4+xUdHJyROsobyjjuOh/r7UFGcEXIOfx yXGUHeP+1Sx5lXvaJS7trsSlXdy3N2ubIOvrMKsQchPVfj5HLdUy4r26LupTQPbp6Ga7 WVPmhyLyCt1PPndGzH+PB+lQITlJXkCEaYxYv0eJ1GnCTLYagrkA/rIm1pQ3ZuAURinI TT+A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de13si12861251edb.525.2021.03.23.04.31.46; Tue, 23 Mar 2021 04:32:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231178AbhCWLab (ORCPT + 99 others); Tue, 23 Mar 2021 07:30:31 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:14434 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229879AbhCWLaQ (ORCPT ); Tue, 23 Mar 2021 07:30:16 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4F4Tdc6ZCbzkdTm; Tue, 23 Mar 2021 19:28:36 +0800 (CST) Received: from huawei.com (10.175.112.208) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.498.0; Tue, 23 Mar 2021 19:30:03 +0800 From: Wang Wensheng To: , , , CC: Subject: [PATCH -next] tick: Use the wrapped function to clear the logic Date: Tue, 23 Mar 2021 11:27:43 +0000 Message-ID: <20210323112743.9493-1-wangwensheng4@huawei.com> X-Mailer: git-send-email 2.9.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.112.208] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function tick_check_replacement() is the combination of tick_check_percpu() and tick_check_preferred(). It make the code easy to understand to use the self-described one function. Signed-off-by: Wang Wensheng --- kernel/time/tick-common.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c index 9d3a225..e15bc0e 100644 --- a/kernel/time/tick-common.c +++ b/kernel/time/tick-common.c @@ -348,12 +348,7 @@ void tick_check_new_device(struct clock_event_device *newdev) td = &per_cpu(tick_cpu_device, cpu); curdev = td->evtdev; - /* cpu local device ? */ - if (!tick_check_percpu(curdev, newdev, cpu)) - goto out_bc; - - /* Preference decision */ - if (!tick_check_preferred(curdev, newdev)) + if (!tick_check_replacement(curdev, newdev)) goto out_bc; if (!try_module_get(newdev->owner)) -- 2.9.4