Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4168290pxf; Tue, 23 Mar 2021 04:37:10 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy1abTVVBO+2LUOMX7AGtJdSqlpCZ2pAMl0uhpmWhuI8rIRp4/zs4P44ck0Lr8kFGq+HM60 X-Received: by 2002:a17:906:8447:: with SMTP id e7mr4516664ejy.523.1616499429933; Tue, 23 Mar 2021 04:37:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616499429; cv=none; d=google.com; s=arc-20160816; b=iUL2mOt2AeBtiJEuW4or7AUJBOTrmoH6Q0Q/dgK1mw7y1i6bRQHof+h59P2hoVomtt 99x8KH4x1OBD51yjkiTzHX0YGVGRU8S6Z9Lowdwbk1iRilWsd9L8D8OyxrgfvqBJ5bPT 3iousqFZYBZObM07/dduI7LXxN1IjppRHszNo6t6gIYuNF6M4c7HuV0iicEfmg1oucL1 1ZhltuNmSEOr/9Q1L+jumAh/HX+Gd0rVoNem2wwhLh4q3EcYImSMCRF2M7K/TSucXtia vQzoBRT8z15cadMccJCCyFvZtdseHJzitcaWU6zXOBWTmua/HzhI/E06HFSP5+9jom+m 1dOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=VAx6sQ2cmyLMnd7X341uxb+DDJS8c4wyekM5RUhpBDc=; b=IGEPgafhVt4DaRuvynXPNTQtEZBecoYhl6PlVWwLrxl83NWnhaO085+ZLuM2axqOcj l2QSc/eHNZkz8m0OpdnjgZ7tmWY831T0izvtt/A30C2TtkD5qh5JuQ28XcdawUoVOTO5 Mqyo3Zgt+YNpMhe3bgtn9RSEUzJRCMpdOp0QRo8mYaVZQWK4yoJHSdwllc98OhvYykuE N/dgUJKOronXYB7KSMsLyPSSkamD6M0l2PnCe7zzPuBjKJGWB6KAaXm8cT3eH2bgLshg JGAPwedTaKyNJ5m9yvHvSDYLGmSGatYGavn0k9zuA1Sl7tWIvRfRGOkwv/kFeQ1IdhZp XWrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=alCNHGS9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f20si13760236edr.318.2021.03.23.04.36.47; Tue, 23 Mar 2021 04:37:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=alCNHGS9; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230192AbhCWLfr (ORCPT + 99 others); Tue, 23 Mar 2021 07:35:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:52294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229931AbhCWLf0 (ORCPT ); Tue, 23 Mar 2021 07:35:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1F0A9619B1; Tue, 23 Mar 2021 11:35:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616499325; bh=bd1lHeohaarMedvzn/T2ZYAwtCAyIqbm8WGP2u4zTt4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=alCNHGS9wr4/obiUew2KdTNGQ0P9Z84PzmMzZqBJjpVTV+bcskuVzaWp0dMhCKdaT jCE4qnHPfMKobMQ8h48qgV//u/ZIMhFLA0WY4kWof+6VebCW1+kmB7ScN+TaPM6qT3 aW9b4YrvuyoXg2JNLpf1ItBfsscMTtSm8AZTbS40= Date: Tue, 23 Mar 2021 12:35:23 +0100 From: Greg KH To: Jia-Ju Bai Cc: balbi@kernel.org, weiyongjun1@huawei.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: gadget: legacy: fix error return code of msg_bind() Message-ID: References: <20210307084915.22022-1-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210307084915.22022-1-baijiaju1990@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 07, 2021 at 12:49:15AM -0800, Jia-Ju Bai wrote: > When usb_otg_descriptor_alloc() returns NULL to usb_desc, no error > return code of msg_bind() is assigned. > To fix this bug, status is assigned with -ENOMEM in this case. > > Reported-by: TOTE Robot Reported-by: TOTE Robot > These lines are not written correctly :( Please fix up and resend. thanks, greg k-h