Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4179642pxf; Tue, 23 Mar 2021 04:58:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyzDNkY5R5qBSGiVc78YUWgsm0CYvtfMU5a0x3ChkGeocf90RYTdvQF70FfyyAKVYXghDrn X-Received: by 2002:a17:906:39a:: with SMTP id b26mr4694703eja.158.1616500708542; Tue, 23 Mar 2021 04:58:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616500708; cv=none; d=google.com; s=arc-20160816; b=R9hdqu7aL/S9R5hS6JHZXQv+cW3aYFyH/fD1KMEKhoPmdrLB9p9QaBNaR6FkUALVil 1lafTxmIYOU0tWSVNjoTuGD57PVgmi6qwwRfbuxmpLjvdnuHyntfTAreEqr1WZRyJFYf E0JNplcbdDxcLW2IEgjLJw4nasrw3k4Uz8ilCqtB1X5fKtFJxyP6xd9px6tU6O6Yiw5e tpRrK0137zXd0/trIPkFmlwG84NJr+r3xypxpc0IyRZKMCszwgunNeSM9vQ1ASYO4tLQ QJAFlB9hQO+ZpZy7dTWkCWqOcOGFiWF2ZuliZxhdgxldBNYdUjELmzw3xY3SOToQOyh0 gDeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=LpfcUFDpwQrhFZ7BtRLixEQDWKtoQy0dri4pWm+Z/rg=; b=o0Oj/EeWDts+bzcgMabxZBWIpSe+EOKs4EYkOcmo6snjlgNoHalEjuSYfX6byNeGz4 1Dbw6gSbqm+UccXwO8oFddVMMmO6+XdQdz7gAl1iJz/xqau+NhsMDXugkN+2joDg74jW /+geTHhx3A2ra2gt2iDQAruONskgZo6bO4woVL4YjBgHeSnqBUndy+LKvN9JwbNk8hxY F8IcteHrq54dsJf2gtrX7+82QOYzDoZJf6PczYtIhTdTy8a4TDxj9vFofQfwpNQVbcyQ g5UCDRaNixaJu1FIRPOGIORPloy1UdvjPvc6q0hbKNaS29g6jtw6fUdzbM2PojgSiC9E BIrQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h1si13395964edv.113.2021.03.23.04.58.05; Tue, 23 Mar 2021 04:58:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=vivo.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229675AbhCWL4k (ORCPT + 99 others); Tue, 23 Mar 2021 07:56:40 -0400 Received: from mail-m17635.qiye.163.com ([59.111.176.35]:45476 "EHLO mail-m17635.qiye.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229576AbhCWL4e (ORCPT ); Tue, 23 Mar 2021 07:56:34 -0400 Received: from ubuntu.localdomain (unknown [36.152.145.182]) by mail-m17635.qiye.163.com (Hmail) with ESMTPA id A2ADD400339; Tue, 23 Mar 2021 19:56:31 +0800 (CST) From: zhouchuangao To: Jens Axboe , Christian Brauner , "Eric W. Biederman" , Oleg Nesterov , Thomas Gleixner , Peter Collingbourne , Zhiqiang Liu , linux-kernel@vger.kernel.org Cc: zhouchuangao Subject: [PATCH v2] kernel/signal: Modify the comment of function check_kill_permission() Date: Tue, 23 Mar 2021 04:56:20 -0700 Message-Id: <1616500582-84709-1-git-send-email-zhouchuangao@vivo.com> X-Mailer: git-send-email 2.7.4 X-HM-Spam-Status: e1kfGhgUHx5ZQUtXWQgYFAkeWUFZS1VLWVdZKFlBSE83V1ktWUFJV1kPCR oVCBIfWUFZTk1CTU4eHxlNHk1MVkpNSk1OS0tOQkpCSE9VEwETFhoSFyQUDg9ZV1kWGg8SFR0UWU FZT0tIVUpKS0hKTFVLWQY+ X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6PSo6KTo6Pz8RFjkaSzdLGQg* Eg0KCk5VSlVKTUpNTktLTkJJSUJOVTMWGhIXVQETFA4YEw4aFRwaFDsNEg0UVRgUFkVZV1kSC1lB WUhNVUpOSVVKT05VSkNJWVdZCAFZQUlLTUM3Bg++ X-HM-Tid: 0a785ef18cf9d991kuwsa2add400339 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Maybe it's easier for us to understand the function of check_kill_permission(). Signed-off-by: zhouchuangao --- kernel/signal.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/kernel/signal.c b/kernel/signal.c index f2a1b89..e6b6277 100644 --- a/kernel/signal.c +++ b/kernel/signal.c @@ -823,8 +823,10 @@ static bool kill_ok_by_cred(struct task_struct *t) } /* - * Bad permissions for sending the signal - * - the caller must hold the RCU read lock + * Check whether the caller has permissions to send the signal. + * - The caller must hold the RCU read lock; + * - Return 0 means permission is allowed, otherwise returns the + * corresponding error number. */ static int check_kill_permission(int sig, struct kernel_siginfo *info, struct task_struct *t) -- 2.7.4