Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4208674pxf; Tue, 23 Mar 2021 05:39:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQ1AhILj++5KRyE1JJDIPnB2Fn+4wneczPhSh965PLtaiFQDOPvjb8lQKjSGidC0RdoEx4 X-Received: by 2002:a17:906:af6f:: with SMTP id os15mr4782108ejb.279.1616503194602; Tue, 23 Mar 2021 05:39:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616503194; cv=none; d=google.com; s=arc-20160816; b=vJMGSQd2r+gC1k69Hcb08cFD2t1/XctTpBnQ8FTCOwhlvCs8foOJlf2vt9ytF77Zhn eeLAtGM/9YWYBsiV5QeKUBmM5Kps0DCi2wDCO1+LTPtGISiJA8IdHmw9sVvS5o38K0o+ cbam+YCy6eGuBzKVDq7zWLSEC85kuEGNdplcXummB9MT64J86m4i6/+jk9nCmZHzOPg8 ty8X5fmK+3EWhXkKkFXKKIlDx9tTE2vS+g0LuN0COTuINiH1P/9AyT7MPXQCyNk4cJI0 wHCqwT/8YXKZHg3/EHrGlDpOjj2EN8HtVaCbeC3288kntirzTv/DilRXrKhyJlo/VeSQ y+Fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6Km/izaVM6Slat0ytamrSmhz/wMrqE9/MAVaIDRDuMY=; b=vAzA90yah9cR8qrDuiJ9QrTHCksj2+OEkQw57SLWD5A/9YkkbtIamI3IiRRdadTy2o Bsee27PGSsg5Qrcw0nkfRvhenbRYRlxeq/FrkaoqLbQin2FIN38hH2b0c0aJiRKUworE MfE9q7gBmMG/V/SEnGXiP4owjrI0A5kw7ByOwDFp8jueMXQxsq1LZfXmtQrLHgD0Laut HcH4WjbVO0/uddI7mYHsfFSS1DXqfQgOIi/4JVYgjYK6AZP9ecwsqVManbsksEEn75yv amzfCuIlHrSp6YNCLrCdPOBhM6NRLSRjMcKWB7xJVdYTR7Nb89rztNrUQHiFJ4hLUzhk W32w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="X3dl/67/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f1si13292731ejh.95.2021.03.23.05.39.31; Tue, 23 Mar 2021 05:39:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="X3dl/67/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231201AbhCWMic (ORCPT + 99 others); Tue, 23 Mar 2021 08:38:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:37694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230359AbhCWMiW (ORCPT ); Tue, 23 Mar 2021 08:38:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id F3D40619A5; Tue, 23 Mar 2021 12:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616503101; bh=zN11fVU0Z030qlDrGEzPsWfYkZ1EdchzwyXI5aqwaG8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=X3dl/67/RwkIgaUig79a+MWfmlM0fSAvPrzE0gvYr29ApnHS1EM+mkFeEmtRpaHuP 6laW/WHRsj7BVE1ep8Jw8pJm4QNajpXCqwQSMDKBT2RPf/QnHzSoPKf7k9IhqqAxT3 wdA3KJ8EDTYX7Sd3HEWnq2cHDlup6dekS4TB4FHE= Date: Tue, 23 Mar 2021 13:38:18 +0100 From: Greg KH To: Mihai Carabas Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, bobo.shaobowang@huawei.com, rdunlap@infradead.org Subject: Re: [PATCH v6 1/3] misc/pvpanic: split-up generic and platform dependent code Message-ID: References: <1616431467-14173-1-git-send-email-mihai.carabas@oracle.com> <1616431467-14173-2-git-send-email-mihai.carabas@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1616431467-14173-2-git-send-email-mihai.carabas@oracle.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 22, 2021 at 06:44:25PM +0200, Mihai Carabas wrote: > Split-up generic and platform dependent code in order to be able to re-use > generic event handling code in pvpanic PCI device driver in the next patches. > > The code from pvpanic.c was split in two new files: > - pvpanic.c: generic code that handles pvpanic events > - pvpanic-mmio.c: platform/bus dependent code > > Signed-off-by: Mihai Carabas > --- > drivers/misc/Kconfig | 9 +- > drivers/misc/Makefile | 2 +- > drivers/misc/pvpanic.c | 160 ------------------------------------ > drivers/misc/pvpanic/Kconfig | 19 +++++ > drivers/misc/pvpanic/Makefile | 7 ++ > drivers/misc/pvpanic/pvpanic-mmio.c | 134 ++++++++++++++++++++++++++++++ > drivers/misc/pvpanic/pvpanic.c | 77 +++++++++++++++++ > drivers/misc/pvpanic/pvpanic.h | 15 ++++ > 8 files changed, 254 insertions(+), 169 deletions(-) > delete mode 100644 drivers/misc/pvpanic.c > create mode 100644 drivers/misc/pvpanic/Kconfig > create mode 100644 drivers/misc/pvpanic/Makefile > create mode 100644 drivers/misc/pvpanic/pvpanic-mmio.c > create mode 100644 drivers/misc/pvpanic/pvpanic.c > create mode 100644 drivers/misc/pvpanic/pvpanic.h This patch does not apply to my char-misc-next branch of char-misc.git on git.kernel.org. What did you make it against? Please reabase it against the above branch and resend. thanks, greg k-h