Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4221331pxf; Tue, 23 Mar 2021 06:00:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzuSX3+/USoEcnjRBPfBg+7eUSWO3MxsNizkIhJLwyt751GWsDLPeRuzoU0H+0de5viReul X-Received: by 2002:a05:6402:1393:: with SMTP id b19mr4411235edv.333.1616504415290; Tue, 23 Mar 2021 06:00:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616504415; cv=none; d=google.com; s=arc-20160816; b=Djpb/tdo9rTAyddM65sXvAnCBxEHj+4b6oGI7/wWiHfqfyvPIQ4SZw5rV7yQP0Ywn7 X314Eybo4bfAKFtp/QiLoAPUbZINAzd0qhIOfIp7rlfj+lZL2BfrlvZUirxfyPrFY4tf d9sEZv2HkkUanuOhtJvUOioLdlFv4jj7eWo7SYyv+4xt+uxLuZg2HmBUniJFE/eVdb6u bGxdGSVHEB1n+M+lLxbdHeB0G3P//PRjVU1BywbLbTlIUmVCbhruWeERkIWOq1Fa4cNo cCWyj9Zq4+pXbGPcR+j+cga9ukeiTCeoneNu3F3XGkwK77SRe0iPEQ1dk9txwvu0HKg8 2vcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=19IRUc5+ZB5fvu32721d6m/+pb2FwSn7JGumPUCdqeA=; b=KEilj+H44ceT3MSAKUxx+aRTIr52EJGWioGYsDxrTVSaKjtRuknlZjAJiyOXvEmkDW ougg4pbJ5IEEdWPop2g8JdjndDCcvwI+oIHwOFKls87puKdmw1iDL8PXiQySKaS76LoE M+KuBdoVZuCdjb2VnYbMu9PGPx+7+b75ENRTMS2e7FAKEtCQUt8h+GsjhXp/YOZZshpH Mp6BWHNExXmZtRfOqzB/rBOb1Fk6g+oL/BZ/dUbaj3a+UNCGu3rV+VVPq0/lURCtkCvj TgvqK1ELeHW4dyF1G4J3sYD5L2KImkB6oAL2xN26c8kVC5/4Xbw8q/JiSEAqB1/+NCAK ygaQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ygjjhgvl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n19si13337176ejx.370.2021.03.23.05.59.49; Tue, 23 Mar 2021 06:00:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Ygjjhgvl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231383AbhCWM6w (ORCPT + 99 others); Tue, 23 Mar 2021 08:58:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231366AbhCWM6T (ORCPT ); Tue, 23 Mar 2021 08:58:19 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65DF2C061574 for ; Tue, 23 Mar 2021 05:58:18 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id h13so23327504eds.5 for ; Tue, 23 Mar 2021 05:58:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=19IRUc5+ZB5fvu32721d6m/+pb2FwSn7JGumPUCdqeA=; b=Ygjjhgvl78RcNFPtaR3HwKk4TODDWtrX1LMPQmeA974UcsZTwzEvOe4tZfycjw3Hl3 +RsNbOHBBGevua7JUAwlJXpfcDv6W3UiY7Lq2005RLp790DhV6lDgPcjvuh/LPFHx5xI i/ISVoDaLOGU2sO3JZFFnztC2eouEBJ1cDGr88cU0gcBqAtb3UbZbCSJYjZo/lHesxIN a2yeBUhtgXwkiqUHZTlC7+SXmLen3seNE0Yojzjg1YiASkUpg4KclsX3fQQfQTEtMiBA MLdzUsn2sPa9EsWuPHZ6YTUX/e5lKFnDtLc2y6bQXqBe0BbvHhmn/BS18c6uq59AEkHt XV7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=19IRUc5+ZB5fvu32721d6m/+pb2FwSn7JGumPUCdqeA=; b=bkMLqoS8iSThqdeJ/4Lwt4TRG17q+HdPpCXUwir32jvmJi82FOLo8pofOX80UQ8KNC MWp81WLUIabH3Vkm+Fa97hI6H9QtoZSUeOsTdXEID2F5Smf0M9lv5cD99zlS4F0ezTyB 4OC7ifVN9wfxuYhk6XQebtwXTH4veT/fCGogTtMD+smxiIoZ49qXv7X2dCjemrJThzIS oowvLdh4YX1uRtSbxbi94LQE1B5aFKPc55DFrStohQ5i/gcUAVND2tew8xYJ9z5uBOP7 CG1MIM7VYVfvbaOaTZwZ5fmlF9td2uttcUxHqkabxSj+ZWUZRQ3b3Wy6PY01TeJ9E7cx nx6Q== X-Gm-Message-State: AOAM530sTf8Mr0S/Ow4/L/GBol1A2YyMSELB8SROaydihGTFX5C5Tgs9 kTlb3OqUeiD+o7jXqxcBGP8= X-Received: by 2002:aa7:db53:: with SMTP id n19mr4616284edt.330.1616504297222; Tue, 23 Mar 2021 05:58:17 -0700 (PDT) Received: from agape ([151.57.211.10]) by smtp.gmail.com with ESMTPSA id lu5sm11283699ejb.97.2021.03.23.05.58.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 05:58:16 -0700 (PDT) From: Fabio Aiuto To: gregkh@linuxfoundation.org Cc: joe@perches.com, apw@canonical.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Fabio Aiuto Subject: [PATCH v2 2/9] staging: rtl8723bs: moved function prototype out of core/rtw_ioctl_set.c and core/rtw_mlme.c Date: Tue, 23 Mar 2021 13:56:29 +0100 Message-Id: X-Mailer: git-send-email 2.20.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org fix the following checkpatch issues: WARNING: externs should be avoided in .c files 40: FILE: drivers/staging/rtl8723bs/core/rtw_ioctl_set.c:40: +u8 rtw_do_join(struct adapter *padapter); WARNING: externs should be avoided in .c files 15: FILE: drivers/staging/rtl8723bs/core/rtw_mlme.c:15: +extern u8 rtw_do_join(struct adapter *padapter); moved function prototype in include/rtw_ioctl_set.h Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 1 - drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 -- drivers/staging/rtl8723bs/include/rtw_ioctl_set.h | 2 ++ 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c index cb14855742f7..7d858cae2395 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c +++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c @@ -37,7 +37,6 @@ u8 rtw_validate_ssid(struct ndis_802_11_ssid *ssid) return ret; } -u8 rtw_do_join(struct adapter *padapter); u8 rtw_do_join(struct adapter *padapter) { struct list_head *plist, *phead; diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c index 95cfef118a94..1ee86ec2dee7 100644 --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c @@ -12,8 +12,6 @@ #include #include -extern u8 rtw_do_join(struct adapter *padapter); - int rtw_init_mlme_priv(struct adapter *padapter) { int i; diff --git a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h index d6d3c39a69c6..31424bf2d926 100644 --- a/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h +++ b/drivers/staging/rtl8723bs/include/rtw_ioctl_set.h @@ -22,6 +22,8 @@ u8 rtw_set_802_11_connect(struct adapter *padapter, u8 *bssid, struct ndis_802_1 u8 rtw_validate_bssid(u8 *bssid); u8 rtw_validate_ssid(struct ndis_802_11_ssid *ssid); +u8 rtw_do_join(struct adapter *padapter); + u16 rtw_get_cur_max_rate(struct adapter *adapter); #endif -- 2.20.1