Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4236650pxf; Tue, 23 Mar 2021 06:16:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzjVS8mD4bhou59KoG5gznLqtnzV1jCk8e7hrByO2B/ZMKNNgywulivQQ4v6PyZeSO6xfDf X-Received: by 2002:a50:ec81:: with SMTP id e1mr4574780edr.0.1616505402688; Tue, 23 Mar 2021 06:16:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616505402; cv=none; d=google.com; s=arc-20160816; b=WHiqZ9pzMbo3mnV+eXE15s5GD0OH9u1RJtQvQk7TeZIRPs2v4zkvKhcvRwKD2qJxnH yScbEU8jIbte1cG5k8tAgvPyIoY20/ap5VzWur6NPfH/tq/Rk4G8LBL8WLbcQbYBVPWY 9L/klxJmJti06O7G5bwliYk4X87HrOFFLniEOLU5psnjta+eIuGpu3/hm7iu6+aI3lsG QB9OIOGQD4SIby610pYMJAfXbYiBZTuUg7XvIXnA4rCaHeWL1F/94soa0l8prelB/xoU DXSuNVo3V1OnnW/X26OlwPxBaElSn36Sl7xdaOWOPLlQ00C/6B0t/2B3s3Zhr84SUNVr SnZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=uHPVFgLkD03f964TduUZWR6MmkD+ufjIH/QjEaY4mJI=; b=gX0mVk44/sumkcIGjhU2CN2oKUNEPPoFWIhLogi4ARM1ZrgGlEfJCgn6GtOA0BPrqF q/SuNudZN1316bNQ3Logy+MJlTTlKU0LBWOiXAJlxpHY1uS4B9WD4eYOAS6XF6n/CvFN CHPkUQUQcsiIMTnb6h1LaRmyfEMpbHB7ZXcBb6DkEcC74DgDd0DJxqD/ejnXA/Cqulom Xq/As0LkG+DYC2aBUfLb7WjhyvL6NrpgcWAcIO9I6XJxmA6kWKjy8HpQbip3KLzqBaqZ fXVUIKb0ewqmFtxrIuw7Zt605GjTC4Iqpk/o/nyKgmE1HkG6PGf3+ctIg5+GvqxxAg+z KcDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NqunR2LC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id do13si12705988ejc.87.2021.03.23.06.16.18; Tue, 23 Mar 2021 06:16:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=NqunR2LC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229884AbhCWNMZ (ORCPT + 99 others); Tue, 23 Mar 2021 09:12:25 -0400 Received: from mail.kernel.org ([198.145.29.99]:44530 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231301AbhCWNMN (ORCPT ); Tue, 23 Mar 2021 09:12:13 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id BF939619B8; Tue, 23 Mar 2021 13:12:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616505133; bh=vCYR3ZBZvyax7SeVVHE9u9H/gK+P9HuMDSSUVInEa3k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=NqunR2LCqbRdIrWeRH4B/w/oeXwFFoAMUYyiluOZ/KAlbO9qURC8kLON+PQr0Gyl6 ZS8k9UJxqIhWQ4EkV9hyMhAxKS/4g1G/kvV0947eefBXpL3pv+Wxg0sI1PBduGOToM fZL2JbVdrZd0wt7vBFDH7lJQUG5Pkh6wP8k1udBPn0+oYknLDmZYeipSGdrUuWgT6I NetmbwcsJWGTEbJ75lAhmMoH+RcJeF/U1mZj2aAWs+W+0aFxIC7PsF9NdqB8eUXQPz /QSF8YKhlstgZzg3sw5QNKNauIamAwE069/OBvfP2VVVPzTB4DRcaNy5oHr+K5Z+SS 1RFunG2xTgGoQ== Date: Tue, 23 Mar 2021 14:12:07 +0100 From: Mauro Carvalho Chehab To: Philipp Gerlesberger Cc: linux-kernel@vger.kernel.org, ij72uhux@stud.informatik.uni-erlangen.de, linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@i4.cs.fau.de, gregkh@linuxfoundation.org, sakari.ailus@linux.intel.com Subject: Re: [PATCH v2 06/12] media: atomisp: Remove defines Message-ID: <20210323141207.2185a4b8@coco.lan> In-Reply-To: <20201214110156.6152-7-Philipp.Gerlesberger@fau.de> References: <20201214110156.6152-1-Philipp.Gerlesberger@fau.de> <20201214110156.6152-7-Philipp.Gerlesberger@fau.de> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Mon, 14 Dec 2020 12:01:50 +0100 Philipp Gerlesberger escreveu: > Remov defines, they don't make sense. > The programmer should know what things need to be static and what not. > Also leave "inline" out and let the compiler decide > > Co-developed-by: Andrey Khlopkov > Signed-off-by: Andrey Khlopkov > Signed-off-by: Philipp Gerlesberger > --- > .../media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h b/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h > index 9cd3d92b34c9..45b72e98bc9f 100644 > --- a/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h > +++ b/drivers/staging/media/atomisp/pci/runtime/rmgr/interface/ia_css_rmgr.h > @@ -21,10 +21,7 @@ > #ifndef __INLINE_RMGR__ > #define STORAGE_CLASS_RMGR_H extern > #define STORAGE_CLASS_RMGR_C > -#else /* __INLINE_RMGR__ */ > -#define STORAGE_CLASS_RMGR_H static inline > -#define STORAGE_CLASS_RMGR_C static inline > -#endif /* __INLINE_RMGR__ */ > +#endif No, that's not the right way to address it. Instead, you should replace the occurrences of those macros at the code and get rid of them. Thanks, Mauro