Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp4254510pxf; Tue, 23 Mar 2021 06:39:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxcv8XrTt5eeq2VJ2lZ5Dl+L+4oDIFDtM/FBYJD8mRJBFCYf9tn81XUyeCEdLqk7wKSDHW8 X-Received: by 2002:a17:907:628a:: with SMTP id nd10mr5052579ejc.326.1616506761186; Tue, 23 Mar 2021 06:39:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616506761; cv=none; d=google.com; s=arc-20160816; b=QmwoTBLJnbgflAUM3hrdK5cPMxO3nYSoMEC8uhxn7YF8CCAHYMfyRB2tNkO8G9FuNP Mz2mziJviOIvvU5DoEDncuszHfiP/jF15pNo7BuRp7hbUH1L60Im1hauXo/y+cjezCkl nYEgGM5u/F8ISqqU93tteIBKdJcnTw2bxrSX/F2BD41dU8XKHGlhYeYqmPsOXAkSJKab pSnTrtF70IZsEPkKWuuKLyrAozfNlfy25wo/5lFdG8hup8y3NdcEs3+x3dK43+g/tByz jAbp+qz5LLgsMW0d4CbFPK13pI1L6K5Pb24RbWFum9Q/AR3WlwEeVNdITVm8o/z1WWb7 Uszw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6cKz8n5QmC0OFzWmvXAyzEKo5cWkscW5AKTVs4gtGL8=; b=HWF+Dhm3UNRJmeuZhtHDdI2uD+hHA12O0Pipduljc6CaXiLaQrLny6UguEXKJMISe4 hXr9MMI/5DqMPbbQkRyF794DESDcYHyEMNzFBqW98vz87MwYN8eW+rFpsRcDXd+UIHct /kXLYKn1bQRNkZFFPk7NFLwScAzG1P0Vm0jDbLbPCYGPUmnqtGwh6m1H1DMYXBg3dpb4 NztQ+KTE/FCMhKrBfGvGQqATMcT7VIMaRsSrcCQ78yY4GASwU0fb8p80Hw8qWdJUGH13 ifx6ABons7ds7dD/rmzWKS2J5RhiIWFAXg7o51DTL6sVbNWLJTYWgOdYBg68H6KX3kNR 8Htw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gyvtQLKp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ca25si13294866edb.204.2021.03.23.06.38.58; Tue, 23 Mar 2021 06:39:21 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=gyvtQLKp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231374AbhCWMyj (ORCPT + 99 others); Tue, 23 Mar 2021 08:54:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:40466 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231219AbhCWMy1 (ORCPT ); Tue, 23 Mar 2021 08:54:27 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2B50A619B9; Tue, 23 Mar 2021 12:54:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1616504066; bh=lKQSbBoD5VY1QPknyOuP3OHdtK0DDF5PhyZzYUxCGtA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gyvtQLKpngyWCBu75hqYmFlyIY7Hwdpf2MF+ofg2eaX032kHj3tZLNK05DI1c18iw nIFB3rkB+IcbjnjJ3tOyKexWpLQHvqkx2vOj8QTyo9z0YMlqlBy+s83r7j0rRGKkUN Y1gDH1iWgq5zE4tUKhFotH8YD2ZI3f5I7FQR5a3E= Date: Tue, 23 Mar 2021 13:54:24 +0100 From: Greg KH To: Shubhankar Kuranagatti Cc: jason.wessel@windriver.com, dianders@chromium.org, arnd@arndb.de, kgdb-bugreport@lists.sourceforge.net, linux-kernel@vger.kernel.org, bkkarthik@pesu.pes.edu Subject: Re: [PATCH 1/2] drivers: misc: kgdbts.c: Fix declaration warning. Message-ID: References: <20210313215808.dt7uvt2suwq4z4x3@kewl-virtual-machine> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210313215808.dt7uvt2suwq4z4x3@kewl-virtual-machine> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 14, 2021 at 03:28:08AM +0530, Shubhankar Kuranagatti wrote: > A new line has been added after declaration. This is done to > maintain code uniformity. > > Signed-off-by: Shubhankar Kuranagatti > --- > drivers/misc/kgdbts.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/misc/kgdbts.c b/drivers/misc/kgdbts.c > index 945701bce553..3ee5acc1c391 100644 > --- a/drivers/misc/kgdbts.c > +++ b/drivers/misc/kgdbts.c > @@ -474,6 +474,7 @@ static int emul_sstep_put(char *put_str, char *arg) > { > if (!arch_needs_sstep_emulation) { > char *ptr = &put_str[11]; > + > if (put_str[1] != 'T' || put_str[2] != '0') > return 1; > kgdb_hex2long(&ptr, &sstep_thread_id); > @@ -502,6 +503,7 @@ static int emul_sstep_put(char *put_str, char *arg) > return 1; > } else { > char *ptr = &put_str[11]; > + > kgdb_hex2long(&ptr, &sstep_thread_id); > } > break; > @@ -740,6 +742,7 @@ static int validate_simple_test(char *put_str) > static int run_simple_test(int is_get_char, int chr) > { > int ret = 0; > + > if (is_get_char) { > /* Send an ACK on the get if a prior put completed and set the * send ack variable > -- > 2.17.1 This patch is corrupted :( Please fix up and resend the whole series properly threaded so our tools can pick them both up at the same time. thanks, greg k-h