Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932609AbWJFUhe (ORCPT ); Fri, 6 Oct 2006 16:37:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932606AbWJFUhe (ORCPT ); Fri, 6 Oct 2006 16:37:34 -0400 Received: from emailer.gwdg.de ([134.76.10.24]:44750 "EHLO emailer.gwdg.de") by vger.kernel.org with ESMTP id S932605AbWJFUhd (ORCPT ); Fri, 6 Oct 2006 16:37:33 -0400 Date: Fri, 6 Oct 2006 22:33:19 +0200 (MEST) From: Jan Engelhardt To: David Howells cc: torvalds@osdl.org, akpm@osdl.org, sfr@canb.auug.org.au, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 1/4] LOG2: Implement a general integer log2 facility in the kernel [try #4] In-Reply-To: <20061006133414.9972.79007.stgit@warthog.cambridge.redhat.com> Message-ID: References: <20061006133414.9972.79007.stgit@warthog.cambridge.redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Spam-Report: Content analysis: 0.0 points, 6.0 required _SUMMARY_ Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 425 Lines: 16 >+ * the massive ternary operator construction >+ (sizeof(n) <= 4) ? \ >+ __ilog2_u32(n) : \ >+ __ilog2_u64(n) \ Should not this be: sizeof(n) <= sizeof(u32) -`J' -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/