Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: eberman=codeaurora.org@mg.codeaurora.org
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4DA72C43462
Subject: Re: [PATCH 6/6] firmware: qcom_scm: Only compile legacy calls on ARM
To:     Stephen Boyd <swboyd@chromium.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     Andy Gross <agross@kernel.org>, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org,
        Brian Masney <masneyb@onstation.org>,
        Stephan Gerhold <stephan@gerhold.net>,
        Jeffrey Hugo <jhugo@codeaurora.org>,
        Douglas Anderson <dianders@chromium.org>
References: <20210223214539.1336155-1-swboyd@chromium.org>
 <20210223214539.1336155-7-swboyd@chromium.org>
 <b9174acc-9826-eb82-b399-ed95f7e83085@codeaurora.org>
 <161483844056.1478170.8701629037531614722@swboyd.mtv.corp.google.com>
 <5ac262bf-a70a-4ca3-01a8-d1432732d26f@codeaurora.org>
 <161501150705.1478170.3739297122787060750@swboyd.mtv.corp.google.com>
 <YEUQlY4X1e2PO8tl@builder.lan>
 <161647057967.3012082.16471020030801311825@swboyd.mtv.corp.google.com>
From:   Elliot Berman <eberman@codeaurora.org>
Message-ID: <c0dbcf6c-9f6f-2103-68bd-3d06420f309a@codeaurora.org>
Date:   Tue, 23 Mar 2021 11:27:05 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <161647057967.3012082.16471020030801311825@swboyd.mtv.corp.google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/22/2021 8:36 PM, Stephen Boyd wrote:
> Quoting Bjorn Andersson (2021-03-07 09:42:45)
>> On Sat 06 Mar 00:18 CST 2021, Stephen Boyd wrote:
>>
>>> Quoting Elliot Berman (2021-03-05 10:18:09)
>>>> On 3/3/2021 10:14 PM, Stephen Boyd wrote:
>>>>> Quoting Elliot Berman (2021-03-03 19:35:08)
>>>>
>>>>   > +    desc.args[0] = flags;
>>>>   > +    desc.args[1] = virt_to_phys(entry);
>>>>   > +
>>>>   > +    return scm_legacy_call_atomic(NULL, &desc, NULL);
>>>>   > +}
>>>>   > +EXPORT_SYMBOL(qcom_scm_set_cold_boot_addr);
>>>>
>>>> This should still be qcom_scm_call.
>>>
>>> You mean s/scm_legacy_call_atomic/qcom_scm_call/ right?
>>>
>>> I don't really want to resend the rest of the patches if this last one
>>> is the only one that needs an update. This was a semi-RFC anyway so
>>> maybe it's fine if the first 5 patches get merged and then I can resend
>>> this one? Otherwise I will resend this again next week or so with less
>>> diff for this patch.
>>
>> I'm fine with merging the first 5, but was hoping that Elliot could
>> provide either a "Reviewed-by" or at least an "Acked-by" on these.
>>
> 
> I'll take the silence as I should resend the whole series?
> 

I thought Bjorn was accepting the first 5 already, my apologies.

Patches 1-5:
Acked-by: Elliot Berman <eberman@codeaurora.org>