Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 23 Mar 2021 18:52:54 +0000
From:   Lee Jones <lee.jones@linaro.org>
To:     Mark Brown <broonie@kernel.org>
Cc:     Andreas Kemnade <andreas@kemnade.info>, j.neuschaefer@gmx.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD
Message-ID: <20210323185254.GZ2916463@dell>
References: <20210308212952.20774-1-andreas@kemnade.info>
 <20210310094821.GB701493@dell>
 <20210311184033.GJ4962@sirena.org.uk>
 <20210322145925.GY2916463@dell>
 <20210323171143.GA5490@sirena.org.uk>
 <20210323172002.GY2916463@dell>
 <20210323174841.GD5490@sirena.org.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210323174841.GD5490@sirena.org.uk>
Precedence: bulk

On Tue, 23 Mar 2021, Mark Brown wrote:

> On Tue, Mar 23, 2021 at 05:20:02PM +0000, Lee Jones wrote:
> > On Tue, 23 Mar 2021, Mark Brown wrote:
> > 
> > > On Mon, Mar 22, 2021 at 02:59:25PM +0000, Lee Jones wrote:
> > > > On Thu, 11 Mar 2021, Mark Brown wrote:
> 
> > > > > If there were more users it'd be better to have this in the core so that
> > > > > problems we can detect like cache stuff if that's used but if it's just
> > > > > one broken device it's probably not worth it, this seems like something
> > > > > you'd have to try to end up with and which is going to cause timeout
> > > > > problems with a lot of I2C controllers which would tank performance
> > > > > enough that people would notice.
> 
> > > > So Yoda, is this to go into the core, or stay where it is?
> 
> > > Well, nobody's sent me any patches.
> 
> > Code is still in the driver in v4.
> 
> > My question is; should these functions really live in the SS?
> 
> Perhaps we could avoid using that particular abbreviation.

Too soon?

> Like I say it depends on how common this is - are we seeing other
> devices with the same problem?

I'm not witness to any.  If this is your first encounter too then
maybe just leave it where it is.  At least for the moment.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog