Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 23 Mar 2021 15:12:58 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Don Bollinger <don@thebollingers.org>
Cc:     arndb@arndb.de, linux-kernel@vger.kernel.org,
        brandon_chuang@edge-core.com, wally_wang@accton.com,
        aken_liu@edge-core.com, gulv@microsoft.com, jolevequ@microsoft.com,
        xinxliu@microsoft.com
Subject: Re: [PATCH v2] eeprom/optoe: driver to read/write SFP/QSFP/CMIS
 EEPROMS
Message-ID: <YFn3ahkF4w/IClaw@kroah.com>
References: <20210215193821.3345-1-don@thebollingers.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210215193821.3345-1-don@thebollingers.org>
Precedence: bulk

On Mon, Feb 15, 2021 at 11:38:21AM -0800, Don Bollinger wrote:
> optoe is an i2c based driver that supports read/write access to all
> the pages (tables) of MSA standard SFP and similar devices (conforming
> to the SFF-8472 spec), MSA standard QSFP and similar devices (conforming
> to the SFF-8636 spec) and CMIS and similar devices (conforming to the
> Common Management Interface Specfication).

Given this thread, I think that using the SFP interface/api in the
kernel already seems like the best idea forward.

That being said, your api here is whack, and I couldn't accept it
anyway.

Not for the least being it's not even documented in Documentation/ABI/
like all sysfs files have to be :)

And it feels like you are abusing sysfs for things it was not ment for,
you might want to look into configfs?

But really, these are networking devices, so they should be controllable
using the standard networking apis, not one-off sysfs files.  Moving to
the Linux-standard tools is a good thing, and will work out better in
the end instead of having to encode lots of device-specific state in
userspace like this "raw" api seems to require.

thanks,

greg k-h