Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp17823pxf; Tue, 23 Mar 2021 20:21:35 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhJ27HNBxB8ePhYQP0f9H5+9zM7CS7eCbLncr+Zl7+BSBYHIZIL7a1uAu6MmjMNVYkFG00 X-Received: by 2002:a17:906:3b84:: with SMTP id u4mr1330526ejf.431.1616556094970; Tue, 23 Mar 2021 20:21:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616556094; cv=none; d=google.com; s=arc-20160816; b=A8JdWpDkckgSrU150GZ2bvQEX27PVF4jxbszflrRFMfiU36yl/st/k6hXnUc1ksBYD duqHo4HjZ61BWkD8qk+4/KzBu5ebswKM/FkW5eVDZtoY0cxYZvYHZUHuByJ9w0H+JYCs /NdMYQSA4m39iCJe4evtXNWTG0+oQ8IezGXJUvL0MGOilEonW3ViVnBLB1VWOe5pUkG7 Vo3DqaIG3cmxdM8/suSK1AyYn837S/UsJi7sLoqAa5WpRBJAjXaxPd9RHK5CZOKANIIz GLIPEtr5+8FzogIgSYMCP0F50ZOMWgS6KHHg/FAVF95D0zNzoCTxKJC5FEUCn0ThfbGL ydbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject; bh=pAFAJSDpvcBAuCBLB6s7IJ4vJaPNCoHrxlyRCKb3/xI=; b=lGNsrosb9rKLyI5FwrEkR6GufXhxrNUgjsvca5sFYDTCjHnmYLRmzLeqpNymkWHyl6 xxGhe/6GlWc8An0uKiqBjPVYBfsOs1oMkWA7Pi5WjJ8B8NmjMXzShZUMllvAjiA7QghD y0QwpOsLmZEQOVca+lnxGI8ELRyJ74YEJ4ldTh5GDl3Y+BAAXa1onS1MaqEIzxwtsnOu DI6BGSBpdrVm2hFwfdzkpoWzOamd0dfgae/bpB3vzUHVAyrxfGztudchZ0Up0awhoJjT 3KPXyIdRSQ5KOmCZxtBPK+uUy/0XY62go+ufD1PBs0qkjTAvXKOm/DEa5/ONblWVKdhD h9Yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a17si752860eju.485.2021.03.23.20.21.11; Tue, 23 Mar 2021 20:21:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232753AbhCWPOx (ORCPT + 99 others); Tue, 23 Mar 2021 11:14:53 -0400 Received: from www262.sakura.ne.jp ([202.181.97.72]:65318 "EHLO www262.sakura.ne.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232721AbhCWPOm (ORCPT ); Tue, 23 Mar 2021 11:14:42 -0400 Received: from fsav104.sakura.ne.jp (fsav104.sakura.ne.jp [27.133.134.231]) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTP id 12NFEeOU062008; Wed, 24 Mar 2021 00:14:40 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Received: from www262.sakura.ne.jp (202.181.97.72) by fsav104.sakura.ne.jp (F-Secure/fsigk_smtp/550/fsav104.sakura.ne.jp); Wed, 24 Mar 2021 00:14:40 +0900 (JST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/fsav104.sakura.ne.jp) Received: from [192.168.1.9] (M106072142033.v4.enabler.ne.jp [106.72.142.33]) (authenticated bits=0) by www262.sakura.ne.jp (8.15.2/8.15.2) with ESMTPSA id 12NFEekn062005 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NO); Wed, 24 Mar 2021 00:14:40 +0900 (JST) (envelope-from penguin-kernel@i-love.sakura.ne.jp) Subject: Re: [RFC PATCH 2/2] integrity: double check iint_cache was initialized To: Mimi Zohar , Dmitry Vyukov Cc: linux-integrity@vger.kernel.org, James Morris , "Serge E . Hallyn" , linux-security-module , LKML , Eric Biggers References: <20210319200358.22816-1-zohar@linux.ibm.com> <20210319200358.22816-2-zohar@linux.ibm.com> <8450c80a-104a-3f36-0963-0ae8fa69e0f2@i-love.sakura.ne.jp> <1a2245c6-3cab-7085-83d3-55b083619303@i-love.sakura.ne.jp> <8039976be3df9bd07374fe4f1931b8ce28b89dab.camel@linux.ibm.com> <8a8763a7-eeeb-3578-d50c-c15919fbe1f9@i-love.sakura.ne.jp> <3ed2004413e0ac07c7bd6f10294d6b6fac6fdbf3.camel@linux.ibm.com> From: Tetsuo Handa Message-ID: Date: Wed, 24 Mar 2021 00:14:39 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.3; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <3ed2004413e0ac07c7bd6f10294d6b6fac6fdbf3.camel@linux.ibm.com> Content-Type: text/plain; charset=iso-8859-15 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021/03/23 23:47, Mimi Zohar wrote: > Initially I also questioned making "integrity" an LSM. Perhaps it's > time to reconsider. For now, it makes sense to just fix the NULL > pointer dereferencing. Do we think calling panic() as "fix the NULL pointer dereferencing" ?