Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp78198pxf; Tue, 23 Mar 2021 22:49:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVI+XxwwN/ms03mDBSf/JgNbvzFJC46QsTxhOZaShyq24du9ggms4kn2xUVJGDqGZjOSlI X-Received: by 2002:a17:906:cb18:: with SMTP id lk24mr1783769ejb.70.1616564966980; Tue, 23 Mar 2021 22:49:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616564966; cv=none; d=google.com; s=arc-20160816; b=g412KzERpi7BmiKYV2jF29d3MiRRMZEEMcKDQn5V4VBq2UnVexb67r2bTfTuklXKNQ RC9WXHgKTxVvE6WSRDNUOvgN4uT1Ay4v7j8vE60k+CJaTWQkSXfvkJtX3Wuzf7MslLJr x423BBtiLUE4dpvRBQD5Wjrs4SJudagKkRJoMcLZZ+0dopThr6BTPIEgi4eCBsPNdGBs nDV8AUEoN7xqFiOZL1maOHtEeluReh/IFCEBSWp5ZQP3ZcEk7YDOO20+02K0qx0GlEga i9/5yfhpUbkRBR8140wMHJkliU8k58ha0FT2omf88kSq0eT0dJ8RcvTg8SXAye7kcrjE iA9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:subject:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:dkim-signature; bh=uvFq+Kc5ZBHy3S9lipYlZNBR57AfmiflcCRMDFpDWAw=; b=Mk8+zbUMqkxF0C5I8q5JQ7wMHsQWOngTdey8VreH5aW/tUeDVyIZPMALoMRCVgAew4 O8zF2uTEOqINe5TgHd0UaxVW1SIJrQgfoHBIGxsKixvysv50lxjimkvlHL7sK5MFD0om JVC5vPiIT2oO+X021Ox/+pbIk0bH8WwUEJIX69F7rzruG4g/ZsxJwd842YUQhppymF+/ 2QrunJ+1lQa84clKE+oeklsXfjbcTb4IdTN+Cuq0EsLoYKRDBxaA/4Ki/6J2lKwin8ko x0e1OhPQ8NU+/8NgeFVaA+dwItbbFPSvi9Eyh82ch3/5RBqyXOGjUhWn3R4WzHiqPktF aK1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=KL1e3lBg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p25si937224edm.297.2021.03.23.22.49.04; Tue, 23 Mar 2021 22:49:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@deltatee.com header.s=20200525 header.b=KL1e3lBg; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233155AbhCWQWJ (ORCPT + 99 others); Tue, 23 Mar 2021 12:22:09 -0400 Received: from ale.deltatee.com ([204.191.154.188]:35760 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233283AbhCWQVo (ORCPT ); Tue, 23 Mar 2021 12:21:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=deltatee.com; s=20200525; h=Subject:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:content-disposition; bh=uvFq+Kc5ZBHy3S9lipYlZNBR57AfmiflcCRMDFpDWAw=; b=KL1e3lBgC4m9cW7SgdHDBgaqVI WhQyyoiX8DB8RF50zbxPc1W3GoBOkrF3Og5waUB9spSRTigwH1VE72RO8Z7nqybyc2TeNht9wcmcf c2CAIl0dEVF9dRZpVNTR0hHEbjwZ7dvyuUv9Gx6MzzfeMK7nMYaHoUls2B1FZeAYt3L8yZnLMwM5U bvk3zYfTW03exmO/l8WXys4Cno2XVWuAXXTM/0Dua2xOXbVn/ObETyXcNOm9D9AHrZxctuJBcZvaE GSMx3g+7AxW+bC5AbRTonGKg+gtKf+mFEXzDAQcTz4xmaonJJDo5btZBS8PcZua61RlA2EZum8eIU 8WlkBVPw==; Received: from guinness.priv.deltatee.com ([172.16.1.162]) by ale.deltatee.com with esmtp (Exim 4.92) (envelope-from ) id 1lOjmk-0005cx-BB; Tue, 23 Mar 2021 10:21:39 -0600 To: Dan Carpenter Cc: Vinod Koul , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: From: Logan Gunthorpe Message-ID: <603f6cf3-ed7b-ae5c-6689-f13390385037@deltatee.com> Date: Tue, 23 Mar 2021 10:21:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-CA Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.162 X-SA-Exim-Rcpt-To: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, vkoul@kernel.org, dan.carpenter@oracle.com X-SA-Exim-Mail-From: logang@deltatee.com X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on ale.deltatee.com X-Spam-Level: X-Spam-Status: No, score=-8.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, GREYLIST_ISWHITE,NICE_REPLY_A autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [PATCH] dmaengine: plx_dma: add a missing put_device() on error path X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-03-23 7:19 a.m., Dan Carpenter wrote: > Add a missing put_device(&pdev->dev) if the call to > dma_async_device_register(dma); fails. > > Fixes: 905ca51e63be ("dmaengine: plx-dma: Introduce PLX DMA engine PCI driver skeleton") > Signed-off-by: Dan Carpenter Good catch. Thanks Dan! Reviewed-by: Logan Gunthorpe Logan