Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] drivers/media/pci/bt8xx/bttv-cards: fix typos
To:     Xiaofeng Cao <cxfcosmos@gmail.com>, mchehab@kernel.org
Cc:     hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org,
        linux-kernel@vger.kernel.org, Xiaofeng Cao <caoxiaofeng@yulong.com>
References: <20210323122546.16262-1-caoxiaofeng@yulong.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <b297b819-8837-cfa0-0a62-d40958697bb2@infradead.org>
Date:   Tue, 23 Mar 2021 10:39:57 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210323122546.16262-1-caoxiaofeng@yulong.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,
Please see a few comments below.

On 3/23/21 5:25 AM, Xiaofeng Cao wrote:
> change 'vodeo'     to 'video'
> change 'nevery'    to 'never'
> change 'is'        to 'it'
> change 'connevted' to 'connected'
> change 'swichers'  to 'switchers'
> change 'strucure'  to 'structure'
> change 'unblanced' to 'unbalanced'
> change 'fonctionality' to 'functionality'
> 
> Signed-off-by: Xiaofeng Cao <caoxiaofeng@yulong.com>
> ---
>  drivers/media/pci/bt8xx/bttv-cards.c | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/media/pci/bt8xx/bttv-cards.c b/drivers/media/pci/bt8xx/bttv-cards.c
> index ca20b806e82d..9a07e1094978 100644
> --- a/drivers/media/pci/bt8xx/bttv-cards.c
> +++ b/drivers/media/pci/bt8xx/bttv-cards.c

> @@ -2506,7 +2506,7 @@ struct tvcard bttv_tvcards[] = {
>  	     one external BNC composite input (mux 2)
>  	     three internal composite inputs (unknown muxes)
>  	     an 18-bit stereo A/D (CS5331A), which has:
> -	       one external stereo unblanced (RCA) audio connection
> +	       one external stereo unbalanced(RCA) audio connection

Please leave a space between unbalanced and (RCA).

>  	       one (or 3?) internal stereo balanced (XLR) audio connection
>  	       input is selected via gpio to a 14052B mux
>  		 (mask=0x300, unbal=0x000, bal=0x100, ??=0x200,0x300)

> @@ -4580,7 +4580,7 @@ static void xguard_muxsel(struct bttv *btv, unsigned int input)
>  }
>  static void picolo_tetra_init(struct bttv *btv)
>  {
> -	/*This is the video input redirection fonctionality : I DID NOT USED IT. */
> +	/*This is the video input redirection functionality : I DID NOT USED IT. */

	                                                      I DID NOT USE IT. *

>  	btwrite (0x08<<16,BT848_GPIO_DATA);/*GPIO[19] [==> 4053 B+C] set to 1 */
>  	btwrite (0x04<<16,BT848_GPIO_DATA);/*GPIO[18] [==> 4053 A]  set to 1*/
>  }


thanks.
-- 
~Randy