Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] fs/dcache: fix typos and sentence disorder
To:     Xiaofeng Cao <cxfcosmos@gmail.com>, viro@zeniv.linux.org.uk
Cc:     linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        Xiaofeng Cao <caoxiaofeng@yulong.com>
References: <20210323065245.15083-1-caoxiaofeng@yulong.com>
From:   Randy Dunlap <rdunlap@infradead.org>
Message-ID: <36a2d11d-8413-f4a7-9f69-fe513d26c4aa@infradead.org>
Date:   Tue, 23 Mar 2021 10:42:14 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210323065245.15083-1-caoxiaofeng@yulong.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/22/21 11:52 PM, Xiaofeng Cao wrote:
> change 'sould' to 'should'
> change 'colocated' to 'co-located'
> change 'talke' to 'take'
> reorganize sentence
> 
> Signed-off-by: Xiaofeng Cao <caoxiaofeng@yulong.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> v2:change 'colocated' to 'co-located' instead of 'collocated'
>  fs/dcache.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/dcache.c b/fs/dcache.c
> index 7d24ff7eb206..c23834334314 100644
> --- a/fs/dcache.c
> +++ b/fs/dcache.c
> @@ -741,7 +741,7 @@ static inline bool fast_dput(struct dentry *dentry)
>  	unsigned int d_flags;
>  
>  	/*
> -	 * If we have a d_op->d_delete() operation, we sould not
> +	 * If we have a d_op->d_delete() operation, we should not
>  	 * let the dentry count go to zero, so use "put_or_lock".
>  	 */
>  	if (unlikely(dentry->d_flags & DCACHE_OP_DELETE))
> @@ -1053,7 +1053,7 @@ struct dentry *d_find_alias_rcu(struct inode *inode)
>  	struct dentry *de = NULL;
>  
>  	spin_lock(&inode->i_lock);
> -	// ->i_dentry and ->i_rcu are colocated, but the latter won't be
> +	// ->i_dentry and ->i_rcu are co-located, but the latter won't be
>  	// used without having I_FREEING set, which means no aliases left
>  	if (likely(!(inode->i_state & I_FREEING) && !hlist_empty(l))) {
>  		if (S_ISDIR(inode->i_mode)) {
> @@ -1297,7 +1297,7 @@ void shrink_dcache_sb(struct super_block *sb)
>  EXPORT_SYMBOL(shrink_dcache_sb);
>  
>  /**
> - * enum d_walk_ret - action to talke during tree walk
> + * enum d_walk_ret - action to take during tree walk
>   * @D_WALK_CONTINUE:	contrinue walk
>   * @D_WALK_QUIT:	quit walk
>   * @D_WALK_NORETRY:	quit when retry is needed
> @@ -2156,8 +2156,8 @@ EXPORT_SYMBOL(d_obtain_alias);
>   *
>   * On successful return, the reference to the inode has been transferred
>   * to the dentry.  In case of an error the reference on the inode is
> - * released.  A %NULL or IS_ERR inode may be passed in and will be the
> - * error will be propagate to the return value, with a %NULL @inode
> + * released.  A %NULL or IS_ERR inode may be passed in and the error will
> + * be propagated to the return value, with a %NULL @inode
>   * replaced by ERR_PTR(-ESTALE).
>   */
>  struct dentry *d_obtain_root(struct inode *inode)
> 


-- 
~Randy