Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Hariprasad Kelam <hkelam@marvell.com>
To:     Andrew Lunn <andrew@lunn.ch>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kuba@kernel.org" <kuba@kernel.org>,
        "davem@davemloft.net" <davem@davemloft.net>,
        Sunil Kovvuri Goutham <sgoutham@marvell.com>,
        Linu Cherian <lcherian@marvell.com>,
        Geethasowjanya Akula <gakula@marvell.com>,
        Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
        Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
Subject: Re: [net-next PATCH 2/8] octeontx2-pf: Add ethtool priv flag to
 control PAM4 on/off
Thread-Topic: [net-next PATCH 2/8] octeontx2-pf: Add ethtool priv flag to
 control PAM4 on/off
Thread-Index: AdcgEF1FcfWijR+8S5qGD0z4+6AE5Q==
Date:   Tue, 23 Mar 2021 18:59:39 +0000
Message-ID: <MWHPR18MB14214BF3FE4059554CDA2A16DE649@MWHPR18MB1421.namprd18.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7ac7bf0b-072c-4e5f-4b51-08d8ee2dcf96
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 18:59:39.4658
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: JtAewUvZcmxdq/YjZwv4nkfFm1Op+lOJCb3fJnzblOCKY9q9AcT4AZ1z0YieQBCHO3iZMoXzDCNw3DD1X+k9Aw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW3PR18MB3673
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761
 definitions=2021-03-23_09:2021-03-23,2021-03-23 signatures=0
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Andrew,

Please see inline,

> -----Original Message-----
> From: Andrew Lunn <andrew@lunn.ch>
> Sent: Sunday, March 21, 2021 7:58 PM
> To: Hariprasad Kelam <hkelam@marvell.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; kuba@kernel.org=
;
> davem@davemloft.net; Sunil Kovvuri Goutham <sgoutham@marvell.com>;
> Linu Cherian <lcherian@marvell.com>; Geethasowjanya Akula
> <gakula@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>;
> Subbaraya Sundeep Bhatta <sbhatta@marvell.com>
> Subject:  Re: [net-next PATCH 2/8] octeontx2-pf: Add ethtool priv flag to
> control PAM4 on/off
>=20
> On Sun, Mar 21, 2021 at 05:39:52PM +0530, Hariprasad Kelam wrote:
> > From: Felix Manlunas <fmanlunas@marvell.com>
> >
> > For PHYs that support changing modulation type (NRZ or PAM4), enable
> > these
> > commands:
> >
> >         ethtool --set-priv-flags  ethX pam4 on
> >         ethtool --set-priv-flags  ethX pam4 off    # means NRZ modulati=
on
> >         ethtool --show-priv-flags ethX
>=20
> Why is this not derived from the link mode? How do other Vendors support
> this in their high speed MAC/PHY combinations.
>=20
> Please stop using priv flags like this. This is not a Marvell specific pr=
oblem.
> Any high speed MAC/PHY combination is going to need some way to
> configure this. So please think about the best generic solution.
>=20
> This combined with your DSA changes give me a bad feeling. It seems like =
you
> are just trying to dump your SDK features into the kernel, without proper=
ly
> integrating the features in a vendor neutral way.
>=20

Thanks for your suggestion .  Will try to evaluate this can be achieved thr=
ough link mode or any generic solution.
Will try to submit his feature as a separate patch.

Thanks,
Hariprasad k
> 	Andrew