Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210323201450.12060-1-oliver.staebler@bytesatwork.ch>
In-Reply-To: <20210323201450.12060-1-oliver.staebler@bytesatwork.ch>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Tue, 23 Mar 2021 17:28:53 -0300
Message-ID: <CAOMZO5B_uHS_Z2LuMwHDmn9erORrsrNBMHMjkW-hW+pnfHZThQ@mail.gmail.com>
Subject: Re: [PATCH] arm64: dts: imx8mm: Fix pad control of SD1_DATA0
To:     =?UTF-8?Q?Oliver_St=C3=A4bler?= <oliver.staebler@bytesatwork.ch>
Cc:     Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Sascha Hauer <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Oliver,

On Tue, Mar 23, 2021 at 5:15 PM Oliver St=C3=A4bler
<oliver.staebler@bytesatwork.ch> wrote:
>
> Fix address of the pad control register
> (IOMUXC_SW_PAD_CTL_PAD_SD1_DATA0) for SD1_DATA0_GPIO2_IO2.  This seems
> to be a typo but it leads to an exception when pinctrl is applied due to
> wrong memory address access.
>
> Signed-off-by: Oliver St=C3=A4bler <oliver.staebler@bytesatwork.ch>

I checked in the RM and your patch is correct, thanks:

Reviewed-by: Fabio Estevam <festevam@gmail.com>

I will send a patch fixing imx8mq-pinfunc.h as it has the same error.