Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Song Liu <songliubraving@fb.com>
To:     Arnaldo Carvalho de Melo <acme@kernel.org>
CC:     Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Kernel Team <Kernel-team@fb.com>, Jiri Olsa <jolsa@kernel.org>
Subject: Re: [PATCH v2 0/3] perf-stat: share hardware PMCs with BPF
Thread-Topic: [PATCH v2 0/3] perf-stat: share hardware PMCs with BPF
Thread-Index: AQHXGqn3m2pRtlCATE6KZ0qUM3kt26qHp6sAgACBEACAAPZFAIABIw8AgAAwyYCAAAOcAIAACTCAgAD17gCAAAZrAIAABJ8AgAab7wCAAASLAA==
Date:   Tue, 23 Mar 2021 21:26:39 +0000
Message-ID: <9F55EE0A-3B60-46E8-B6AF-22259BD1B6D1@fb.com>
References: <CAM9d7ci=hfFjq3+XuBcCZ0TUJxv6AmdFk0dkHFQD3wx27aJMjA@mail.gmail.com>
 <YFH//FRPvrPswhld@kernel.org> <7D48A756-C253-48DE-B536-826314778404@fb.com>
 <YFPCul51MjrlY65P@krava> <388AF530-5176-4DB9-93C4-6C302432CE12@gmail.com>
 <3E65B60E-B120-4E1A-BAF2-2FAEF136A4CD@fb.com>
 <CAM9d7ch_axD_4E0W7MEx8ueeq9QsvhxNWaJ0J3AtVgeKqKQmbA@mail.gmail.com>
 <YFTEsOhbx4Il1nji@kernel.org>
 <CAM9d7cgoP28V_ONk2AJeu=Y7RQ8vzovzW=pGVYtERe97+ZH0Aw@mail.gmail.com>
 <EC00E37D-8587-4662-8E30-7AD5F874FA84@fb.com> <YFpZPijlMSyfIVbl@kernel.org>
In-Reply-To: <YFpZPijlMSyfIVbl@kernel.org>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4CC1A55B4B02F944972EEEDCD82E503E@namprd15.prod.outlook.com>
X-MS-Exchange-CrossTenant-Network-Message-Id: 9247d8d4-5b0f-4fe5-0e60-08d8ee4258d1
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 21:26:39.6314
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 0fVyXIUWNqUbmJumjKo/4M+VYPwpXyea5p39anBA014ZFYcrlEkP7koOe4o8Dclomgb24StkfcpV1fi69uTceA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR15MB2455
X-OriginatorOrg: fb.com
Content-Transfer-Encoding: quoted-printable
X-Proofpoint-UnRewURL: 0 URL was un-rewritten
MIME-Version: 1.0
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.369,18.0.761
 definitions=2021-03-23_11:2021-03-23,2021-03-23 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 mlxscore=0 spamscore=0
 malwarescore=0 clxscore=1015 adultscore=0 mlxlogscore=999 impostorscore=0
 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0
 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2009150000 definitions=main-2103230159
X-FB-Internal: deliver
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Mar 23, 2021, at 2:10 PM, Arnaldo Carvalho de Melo <acme@kernel.org> w=
rote:
>=20
> Em Fri, Mar 19, 2021 at 04:14:42PM +0000, Song Liu escreveu:
>>> On Mar 19, 2021, at 8:58 AM, Namhyung Kim <namhyung@kernel.org> wrote:
>>> On Sat, Mar 20, 2021 at 12:35 AM Arnaldo Carvalho de Melo <acme@kernel.=
org> wrote:
>>>> Em Fri, Mar 19, 2021 at 09:54:59AM +0900, Namhyung Kim escreveu:
>>>>> On Fri, Mar 19, 2021 at 9:22 AM Song Liu <songliubraving@fb.com> wrot=
e:
>>>>>>> On Mar 18, 2021, at 5:09 PM, Arnaldo <arnaldo.melo@gmail.com> wrote:
>>>>>>> On March 18, 2021 6:14:34 PM GMT-03:00, Jiri Olsa <jolsa@redhat.com=
> wrote:
>>>>>>>> On Thu, Mar 18, 2021 at 03:52:51AM +0000, Song Liu wrote:
>>>>>>>>> perf stat -C 1,3,5                  107.063 [sec]
>>>>>>>>> perf stat -C 1,3,5 --bpf-counters   106.406 [sec]
>=20
>>>>>>>> I can't see why it's actualy faster than normal perf ;-)
>>>>>>>> would be worth to find out
>=20
>>>>>>> Isn't this all about contended cases?
>=20
>>>>>> Yeah, the normal perf is doing time multiplexing; while --bpf-counte=
rs
>>>>>> doesn't need it.
>=20
>>>>> Yep, so for uncontended cases, normal perf should be the same as the
>>>>> baseline (faster than the bperf).  But for contended cases, the bperf
>>>>> works faster.
>=20
>>>> The difference should be small enough that for people that use this in=
 a
>>>> machine where contention happens most of the time, setting a
>>>> ~/.perfconfig to use it by default should be advantageous, i.e. no need
>>>> to use --bpf-counters on the command line all the time.
>=20
>>>> So, Namhyung, can I take that as an Acked-by or a Reviewed-by? I'll ta=
ke
>>>> a look again now but I want to have this merged on perf/core so that I
>>>> can work on a new BPF SKEL to use this:
>=20
>>> I have a concern for the per cpu target, but it can be done later, so
>=20
>>> Acked-by: Namhyung Kim <namhyung@kernel.org>
>=20
>>>> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=
=3Dtmp.bpf/bpf_perf_enable
>=20
>>> Interesting!  Actually I was thinking about the similar too. :)
>>=20
>> Hi Namhyung, Jiri, and Arnaldo,
>>=20
>> Thanks a lot for your kind review.=20
>>=20
>> Here is updated 3/3, where we use perf-bench instead of stressapptest.
>=20
> I had to apply this updated 3/3 manually, as there was some munging, its
> all now at:
>=20
> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/log/?h=3Dt=
mp.perf/core
>=20
> Please take a look at the "Committer testing" section I added to the
> main patch, introducing bperf:
>=20
> https://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git/commit/?h=
=3Dtmp.perf/core&id=3D7fac83aaf2eecc9e7e7b72da694c49bb4ce7fdfc
>=20
> And check if I made any mistake or if something else could be added.
>=20
> It'll move to perf/core after my set of automated tests finishes.

Thanks Arnaldo! Looks great!

Song