Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp125664pxf; Wed, 24 Mar 2021 00:32:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwOltXjf/2w8eJJ0KOylWYCL6hx7E1AQZMnml8WtHGv7AuEn2F4BPdq2dQ21oXHecV3bK9a X-Received: by 2002:a17:906:3c46:: with SMTP id i6mr2267065ejg.80.1616571167877; Wed, 24 Mar 2021 00:32:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616571167; cv=none; d=google.com; s=arc-20160816; b=NVIH9PsjDdBj/GIAwC0jJ2zHx6EUEz/oerNBoZEi1xmxHkSJqr5n6Gf2NGBqDAkwpi JNeeVOW00MreXzQ+11t0NUqX3fmQiJsr2lI5MgODgoeB5P+6D7EC7aPE9LnHM6ipR5jn JPGhSWQyu7NWf4MFLJUItHVcofcdQ1BgUkWeNn4wdKVVDYVcxjDv4tY1ETLz6TgzIwA/ 2wpWKaM5l4tSu5U1fI58Bl2er+AWq0adnLRWtAOFb6VVXz1eCvxw4JlYjKtuqlp2XKM6 zIDIfOcZbfBhEELGO6Y/MXNe+kTXR6r/GGmv71hehbOEF3Rf03SgxM2j8OpI8SBi+5vt VTKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rvofdCHxCvwcpYzvV4ThQ9tW1dE3FsuCFAAVo7LtDxM=; b=hi2TohH7WubzXWqhNNRYjF5XEHYG94mGXBSmPTGUTTkYeblEDjnQxS72wcLMJ1qdqj JLcmRmdShEzBOYGAZ3ae/O+BDdZdr3vCR39WVKd9j/i95Q7YkUBlXl0WeWZBbKqJQGmf 8oKrBfZRokme3z3qnawYy60ktPu5wq8Kk5IFiaTDPJYkEGAZXPgos5cITRZc1BaL5smg 4lxVNSJ64zIYxJlaa2xWoj7QaBfTeykhxcxz3T3witnZ+TVgzzOBaWl+DJLBeAdEWYlE kddxGnA5m+mNOSG1N4PvkHdJLFMySOac3o13bw7o8OSYQ3CLH+WYiqPmR82Nn2ONYqUb ll/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CYE5Y74+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k5si1108136ejc.134.2021.03.24.00.32.25; Wed, 24 Mar 2021 00:32:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=CYE5Y74+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233595AbhCWVdn (ORCPT + 99 others); Tue, 23 Mar 2021 17:33:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233464AbhCWVdU (ORCPT ); Tue, 23 Mar 2021 17:33:20 -0400 Received: from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com [IPv6:2607:f8b0:4864:20::102c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 64259C061574; Tue, 23 Mar 2021 14:33:20 -0700 (PDT) Received: by mail-pj1-x102c.google.com with SMTP id ot17-20020a17090b3b51b0290109c9ac3c34so69153pjb.4; Tue, 23 Mar 2021 14:33:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=rvofdCHxCvwcpYzvV4ThQ9tW1dE3FsuCFAAVo7LtDxM=; b=CYE5Y74+IrbPB/cTc6+L56Vy+Ekl+fDZFsbbZoRzAnOlZqrEN0yKSPBOPvyXkbDAe0 +8us0jjucSN47EYClPH/uiUv30T3a5Cyl0Tc6UeJonPQ3H2mPIux6xKgXtqA2OxV6uYp 2lR7wAL7c5EL3vBSTPMstroVDDNgoGHdi8ciieUwUyAip3Vvm8xKGHaYEaUXjJtVrx1M eiPDns+Lq0xEP2Auub0CDI/2o2+VhRNT3ZGdYfjuqCeZiZe1y+2XQz9eyeHItj8UWYIv LIMu4LzMasinFqedjA4YeelKIOUCKrQYElu2+v9nstxHSGxkVlPE5htLNvwpkbVWWt1o tTQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=rvofdCHxCvwcpYzvV4ThQ9tW1dE3FsuCFAAVo7LtDxM=; b=iUfB+D2wch70lDRaqhpMHW06/tuWzrgxTBMyEtRB/OR5/sooyJrsu4ixSNOi/G3Ich EvPGlvkqa/VxhcjOckXQUMROGPOTpkf8IYYs391OXQNK2JQcsIwDNGcF2BNIbbGCGTPe sQ8HxToj59ER70CrV7hM7mVaZBk1XMdFJx16wB7LpMwLjqASgQz5ZVGFFqg/a7EQCV4w j0y6trAILM35eP/1wdkhul+lhiTStLRTjNLmW1XMAz9oFul8gfpBQKaqav1ayAmZPfzt ZmrToyjS/6WNOWIvd/GFQNpSrMFz6ppqvMEt1RG0EOo+FpRM59D5h2birBkzIE0ZHoWA GFLg== X-Gm-Message-State: AOAM532jyUGpMfZHUlb2mZa2ZC08hVoiSkwhhbSLWfC4hrAx/5YZvWuC cldcqaZ4NVzU1TV00QFK6p0= X-Received: by 2002:a17:90a:7045:: with SMTP id f63mr122836pjk.35.1616535199921; Tue, 23 Mar 2021 14:33:19 -0700 (PDT) Received: from google.com ([2620:15c:202:201:4d6b:ca5a:c720:f5c9]) by smtp.gmail.com with ESMTPSA id w18sm137046pjh.19.2021.03.23.14.33.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Mar 2021 14:33:18 -0700 (PDT) Date: Tue, 23 Mar 2021 14:33:16 -0700 From: Dmitry Torokhov To: Paul Cercueil Cc: od@zcrc.me, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/3] input: gpio-keys: Remove extra call to input_sync Message-ID: References: <20210307222240.380583-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210307222240.380583-1-paul@crapouillou.net> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 07, 2021 at 10:22:38PM +0000, Paul Cercueil wrote: > The input_sync() function is already called after the loop in > gpio_keys_report_state(), so it does not need to be called after each > iteration within gpio_keys_gpio_report_event(). > > Signed-off-by: Paul Cercueil Applied, thank you. -- Dmitry