Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Subject: Re: [PATCH v6] mm: cma: support sysfs
To:     Minchan Kim <minchan@kernel.org>
CC:     Andrew Morton <akpm@linux-foundation.org>,
        linux-mm <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>,
        <gregkh@linuxfoundation.org>, <surenb@google.com>,
        <joaodias@google.com>, <willy@infradead.org>, <digetx@gmail.com>
References: <20210324010547.4134370-1-minchan@kernel.org>
 <cbe10402-6574-6e46-9fd9-98b503bd26a4@nvidia.com>
 <YFqxm7UQBtWqH6VU@google.com>
From:   John Hubbard <jhubbard@nvidia.com>
Message-ID: <d224c6bd-f5b1-74f6-2afc-c3d5b0519ba4@nvidia.com>
Date:   Tue, 23 Mar 2021 21:47:27 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <YFqxm7UQBtWqH6VU@google.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2021 04:47:28.6591
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 7a4ee847-30b8-49ce-b603-08d8ee7fedaa
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT025.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3813
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 3/23/21 8:27 PM, Minchan Kim wrote:
...
>>> +static int __init cma_sysfs_init(void)
>>> +{
>>> +	unsigned int i;
>>> +
>>> +	cma_kobj_root = kobject_create_and_add("cma", mm_kobj);
>>> +	if (!cma_kobj_root)
>>> +		return -ENOMEM;
>>> +
>>> +	for (i = 0; i < cma_area_count; i++) {
>>> +		int err;
>>> +		struct cma *cma;
>>> +		struct cma_kobject *cma_kobj;
>>> +
>>> +		cma_kobj = kzalloc(sizeof(*cma_kobj), GFP_KERNEL);
>>> +		if (!cma_kobj) {
>>> +			kobject_put(cma_kobj_root);
>>> +			return -ENOMEM;
>>
>> This leaks little cma_kobj's all over the floor. :)
> 
> I thought kobject_put(cma_kobj_root) should deal with it. No?
> 
If this fails when i > 0, there will be cma_kobj instances that
were stashed in the cma_areas[] array. But this code only deletes
the most recently allocated cma_kobj, not anything allocated on
previous iterations of the loop.

thanks,
-- 
John Hubbard
NVIDIA