Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <1f5247a81077f6cb3c96730b1202bbd61dd1900b.camel@fi.rohmeurope.com>
Subject: Re: [PATCH v3 3/8] extconn: Clean-up few drivers by using managed
 work init
From:   Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Reply-To: matti.vaittinen@fi.rohmeurope.com
To:     Chanwoo Choi <cw00.choi@samsung.com>
Cc:     MyungJoo Ham <myungjoo.ham@samsung.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <mgross@linux.intel.com>,
        gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org, platform-driver-x86@vger.kernel.org
In-Reply-To: <14800e19-da8c-81ba-48ee-cc51cc1925c9@samsung.com>
References: <cover.1616506559.git.matti.vaittinen@fi.rohmeurope.com>
         <CGME20210323135719epcas1p326dfbf8acd6c95703a30d832fb111879@epcas1p3.samsung.com>
         <b1030eddbf0069f2d39e951be1d8e40d6413aeeb.1616506559.git.matti.vaittinen@fi.rohmeurope.com>
         <14800e19-da8c-81ba-48ee-cc51cc1925c9@samsung.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Date:   Wed, 24 Mar 2021 07:02:52 +0200
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello Chanwoo, Greg,

Thanks for the review.

On Wed, 2021-03-24 at 11:09 +0900, Chanwoo Choi wrote:
> Hi,
> 
> Need to fix the work as following:
> s/extconn/extcon
> 
> And I'd like you to use the more correct patch title like the
> following example:
> "extcon: Use resource-managed function for delayed work"

I think Greg merged this already. How should we handle this?

> @@ -112,7 +113,9 @@ static int gpio_extcon_probe(struct
> > platform_device *pdev)
> >  	if (ret < 0)
> >  		return ret;
> >  
> > -	INIT_DELAYED_WORK(&data->work, gpio_extcon_work);
> > +	ret = devm_delayed_work_autocancel(dev, &data->work,
> > gpio_extcon_work);
> > +	if (ret)
> > +		return ret;
> 
> Need to add the error log as following:
> 	if (ret) {
> 		dev_err(dev, "Failed to initialize delayed_work");
> 		return ret;
> 	}	

I could send incremental patch to Greg for this but it does not change
the commit message.

Best Regards
	Matti Vaittinen