Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp207610pxf; Wed, 24 Mar 2021 03:13:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyE45QHG2fCBQDIyCnS42TASc+nzcpund5E3mGvWS9fCfjZ0rDhlM1DmPMHLfwU6KCWkNHR X-Received: by 2002:a05:6402:646:: with SMTP id u6mr2636024edx.250.1616580788642; Wed, 24 Mar 2021 03:13:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616580788; cv=none; d=google.com; s=arc-20160816; b=WS9UWxBbKc36ha7G5xG5bXqrkzwgvqcYwLkEeKtcP/qO872WWSi1+85bl8AlLgVhdc VUpzXZGazWYhtUKaJwTIun2GIZkw2Zk8kaVVUIoqw2X6CnYSzMFGKK615GYnhqIvf2lo twMctXsc781PPSxDz5HxpPFoQVKhJplWpfbQZOhNDd8OkYK9/7Z1AninxQ1RgHwY69Nm S7z25M60i+AW1u5hTQt5EGGcuWLs078aRRKFDRHDCnzR5q16dQwx8MKvUZ2Kje3pVURX aYhXC5NtH2WjSL/dd37/SQsVOGrmVEjDHnwmgcXq/l6l8us7XWx4mbu5h0tLgFEyaIFb uYWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=tKY8w8y/AACF36R/faxPdF/fcIu6eyyU+gaJ7lFi4gU=; b=QU6jrCZf/RMZijI+M/6KbT9ZErFn90V9AQY+hRnGPgZ7qYkvqbhlU14Y1TGOAcHKdb TBLJefzxlYN480i9Gv8aMj9l9lZCYGcyQZdvy/UwsILhXF6xlXWEgUQoEDlQHmgdZCv5 OxIrkV8nKPmxBpCZwHv3EuZhBkVCHsxvKWHcEV3K8xOLPP8x30XwxTHOFMTeLLxvg4Gt PTz9riWpj8DWMH1LurkYqaYz+cz1+VFsnjPPKXtygIAuGBC8gd3hFiaUIeb7gT17IJWI CyFSOJc5yjQQMfhdlPbd91iO552zG3dZxhkbLJ2XNcEAgFJwGPg54ppxWsGo3D+tfnv/ tYwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m7si1450059edd.486.2021.03.24.03.12.46; Wed, 24 Mar 2021 03:13:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235614AbhCXGr5 (ORCPT + 99 others); Wed, 24 Mar 2021 02:47:57 -0400 Received: from lucky1.263xmail.com ([211.157.147.134]:38090 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235642AbhCXGrf (ORCPT ); Wed, 24 Mar 2021 02:47:35 -0400 Received: from localhost (unknown [192.168.167.235]) by lucky1.263xmail.com (Postfix) with ESMTP id A6A71C7C32; Wed, 24 Mar 2021 14:47:32 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 X-ANTISPAM-LEVEL: 2 X-ABS-CHECKED: 0 Received: from localhost.localdomain (unknown [58.22.7.114]) by smtp.263.net (postfix) whith ESMTP id P24306T139685303748352S1616568451588231_; Wed, 24 Mar 2021 14:47:32 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: X-RL-SENDER: jay.xu@rock-chips.com X-SENDER: xjq@rock-chips.com X-LOGIN-NAME: jay.xu@rock-chips.com X-FST-TO: huangtao@rock-chips.com X-SENDER-IP: 58.22.7.114 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 From: Jianqun Xu To: huangtao@rock-chips.com, kever.yang@rock-chips.com, linus.walleij@linaro.org, heiko@sntech.de Cc: linux-gpio@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Jianqun Xu Subject: [PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type Date: Wed, 24 Mar 2021 14:47:30 +0800 Message-Id: <20210324064730.950335-1-jay.xu@rock-chips.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210324064541.949630-1-jay.xu@rock-chips.com> References: <20210324064541.949630-1-jay.xu@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There has spin lock for irq set type already, so drop irq_gc_lock and irq_gc_unlock. Signed-off-by: Jianqun Xu --- drivers/gpio/gpio-rockchip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 048e7eecddba..c9c55614bbef 100644 --- a/drivers/gpio/gpio-rockchip.c +++ b/drivers/gpio/gpio-rockchip.c @@ -406,7 +406,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) irq_set_handler_locked(d, handle_level_irq); raw_spin_lock_irqsave(&bank->slock, flags); - irq_gc_lock(gc); level = rockchip_gpio_readl(bank, bank->gpio_regs->int_type); polarity = rockchip_gpio_readl(bank, bank->gpio_regs->int_polarity); @@ -461,7 +460,6 @@ static int rockchip_irq_set_type(struct irq_data *d, unsigned int type) rockchip_gpio_writel(bank, level, bank->gpio_regs->int_type); rockchip_gpio_writel(bank, polarity, bank->gpio_regs->int_polarity); out: - irq_gc_unlock(gc); raw_spin_unlock_irqrestore(&bank->slock, flags); return ret; -- 2.25.1