Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 24 Mar 2021 13:49:23 +0100
Message-ID: <s5ho8f8ogx8.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Ikjoon Jang <ikjn@chromium.org>
Cc:     Joakim Tjernlund <Joakim.Tjernlund@infinera.com>,
        Jaroslav Kysela <perex@perex.cz>, alsa-devel@alsa-project.org,
        Takashi Iwai <tiwai@suse.com>,
        Gregor Pintar <grpintar@gmail.com>, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Dylan Robinson <dylan_robinson@motu.com>,
        Kai-Heng Feng <kai.heng.feng@canonical.com>,
        Olivia Mackintosh <livvy@base.nu>,
        Alexander Tsoy <alexander@tsoy.me>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: usb-audio: Apply sample rate quirk to Logitech Connect
In-Reply-To: <CAATdQgDrri-tMtu3AOFRcbGHfL6hONDfdMdZh45BusbdAoWfdw@mail.gmail.com>
References: <20210324105153.2322881-1-ikjn@chromium.org>
        <c21de867cf4ccbfcc8cf555c78dc70dd3a47dfe8.camel@infinera.com>
        <CAATdQgDrri-tMtu3AOFRcbGHfL6hONDfdMdZh45BusbdAoWfdw@mail.gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 24 Mar 2021 13:03:14 +0100,
Ikjoon Jang wrote:
> 
> On Wed, Mar 24, 2021, 7:16 PM Joakim Tjernlund <Joakim.Tjernlund@infinera.com>
> wrote:
> 
>     On Wed, 2021-03-24 at 18:51 +0800, Ikjoon Jang wrote:
>     > Logitech ConferenceCam Connect is a compound USB device with UVC and
>     > UAC. Not 100% reproducible but sometimes it keeps responding STALL to
>     > every control transfer once it receives get_freq request.
>     >
>     > This patch adds 046d:0x084c to a snd_usb_get_sample_rate_quirk list.
>     >
>     > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=203419
>     > Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
>    
>     Most Logitech USB headset I got needs a delay in snd_usb_ctl_msg_quirk()
>     Have you tried to add say 20 ms delay in there?
> 
> I didn't try that. But it sounds reasonable to me.
> 
> let me try that quirk here. If that is the case, HID might need that delay
> also. Logitech Group webcam had a similar problem on control xfer of
> get_report from an another interface for HID.

The Logitech devices with 046d:* should be covered generally in
snd_usb_ctl_msg_quirk(), so I guess it's a different problem.
But please check it first.

> And 20ms can be too long if it's applied to every control transfer. I will
> test the device with shorter delay if you didn't try it before.

Actually the delay applied to Logitech devices is from 1 to 2ms, not
20ms.  The 20ms delay is applied for some other devices.  But if
extending the delay fixes the problem, we need to reconsider the delay
length.


Takashi