Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp315721pxf; Wed, 24 Mar 2021 05:59:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyDJooXRmlD86bXNQekrXO+Lrt3vDDLfrbeRfCbFyJLIYv8I6R7BcpxdcLCt/kQKaP71c0s X-Received: by 2002:a17:906:f01:: with SMTP id z1mr3666430eji.235.1616590788817; Wed, 24 Mar 2021 05:59:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616590788; cv=none; d=google.com; s=arc-20160816; b=ooH7QgL7EgWoyzCsGptcf78JIfyENyabjbps4oowC6KptGcFLv8h/42E+chziHdW+H WDt8FwY5gvVaDc4LeR428XoS0HwQdsgE9oruZmK39paaurSTGuzvK2BOlV0XN5AaCfQi lRNjVbiyi/N5AKwfkCWJvOZhDff9qBGQTjL6Tvp5Qe3ESFVupj83RAmRMOHeR3SrgfGO dhO5IT3plUj17Ut3gLWglOjSTnzGKW+Jc73Pf337iCWj3Iup1nH/o1fqH1SRx3CSCvwc 6j0+x/lJ0pPpHyAfducuqAhe/QldNCwP676j/Xv6Pkdgvgg0Rh6hc0yQLRDW9g+WW7Px 474g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dkim-signature; bh=BRsabgXq1j/oZODFUT1sBBvOqEOBW7MpFRgZymkaaUA=; b=pfk9+KVztGX+gd/u9HYM1winXmFW7ksqcSONN2npfo6IAA9arZIoX1+Z2oCQlAr9er Ml0hpstVmXHs6LgdnXeh44Dopgsgl1ByfdeX35+c3Q7W/++o+uDdQZgJgQkeGxfeotoK 35hCxGQXSxT21uS0M58EgJD2gQeyz5gJKTELChkq51lGE8RDSc6trlWo8SgmpFPy5mKL VJHkTxmMbhUCgfG+2hoSR2J5FFOTdRiFJLGEmAvInbL+wVdDK2OvC7LlGxZBahAuy2sl tjkscUaAoklWiIxAGWS+RYiNEB36PUOegnpdLYH3ejAHw5Hu15AvY44RwcZzjOdSG9db EvPA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=A99XLQZD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c17si1567116ede.535.2021.03.24.05.59.25; Wed, 24 Mar 2021 05:59:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=A99XLQZD; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234513AbhCXM5C (ORCPT + 99 others); Wed, 24 Mar 2021 08:57:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234741AbhCXM4f (ORCPT ); Wed, 24 Mar 2021 08:56:35 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4786C061763 for ; Wed, 24 Mar 2021 05:56:34 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id v186so14566819pgv.7 for ; Wed, 24 Mar 2021 05:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=BRsabgXq1j/oZODFUT1sBBvOqEOBW7MpFRgZymkaaUA=; b=A99XLQZDgZ/5k/F3KdS2TsU8Q4orPYziYZf2YsYkzLzMn1xb9ZEnAQkE3CSnhoR4Vg N/tFuW4/K9C4XwdQb2BVjcywh7QQNtf63Kw/lqkcv4bEzdO/qL2jMWPccS6lLuAhEYw6 ykfbZPWc7DHxJKksBDJjK54Ci/zfV0cPJsUBD09g1bvXloVxDnAHlxRaeQuLzajRETqJ VNpbMHiNSRZPdpbkQ7Z5uF3c/lTnDqrgW0TNfvzpZtdAwtOSUqKVzmyb4dIifOv5XNLs 5rHX/BTaT8oEfz0+SABgAc8tTDikOJdpZ+E72T/x2NC3M1yvw0Rjk0PZG6Yhxt6cMsss 1+pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BRsabgXq1j/oZODFUT1sBBvOqEOBW7MpFRgZymkaaUA=; b=Cf54Jt3RYN1JaDCfdvIdr7NVoHon987nSLFkLSf4v54zoi5BAZCXaZIDHWuLgUZ19a gXdmiDwqh32OBqa7ZunrIQ2071gqn3JeLRVS3D/FD+A57ESP7NFZHPjWHQ4liOlfJyvb GxHxWGoGLwsV03swdItde1S4YUZu3Qg9PkUBUlv1fCMmD+183YTQWBrhYtmvQ6W+hLrT yI3d0qaedsQJwk8JWGyQdAvULjKkZTRcOK6go0uYRETiIW/DD5k7fk1sv8DpC3iVvmwl y8uUvTWwvJTQmUbVscNqjtInxkgLhbujb9KdntxNC68wnJLVdiLhPOajjDPusdApkAmm goeA== X-Gm-Message-State: AOAM5305wc6I35Y+45nFXQOhkB8TNtC+bNE4+wVJ8a8MJnnSD1LOCsoE Unj+mWcqZqnIPgeH5oaGL6xYAg== X-Received: by 2002:aa7:9a1a:0:b029:1ee:ea41:9a2b with SMTP id w26-20020aa79a1a0000b02901eeea419a2bmr2923986pfj.42.1616590594380; Wed, 24 Mar 2021 05:56:34 -0700 (PDT) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id i10sm3175415pgo.75.2021.03.24.05.56.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 Mar 2021 05:56:34 -0700 (PDT) Subject: Re: [PATCH] rsxx: remove extraneous 'const' qualifier To: Arnd Bergmann , Joshua Morris , Philip Kelleher Cc: Arnd Bergmann , Nick Desaulniers , Nathan Chancellor , "Gustavo A. R. Silva" , Philip J Kelleher , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com References: <20210323215753.281668-1-arnd@kernel.org> From: Jens Axboe Message-ID: Date: Wed, 24 Mar 2021 06:56:32 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210323215753.281668-1-arnd@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/23/21 3:57 PM, Arnd Bergmann wrote: > From: Arnd Bergmann > > The returned string from rsxx_card_state_to_str is 'const', > but the other qualifier doesn't change anything here except > causing a warning with 'clang -Wextra': > > drivers/block/rsxx/core.c:393:21: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers] > static const char * const rsxx_card_state_to_str(unsigned int state) Applied, thanks Arnd. -- Jens Axboe