Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Wed, 24 Mar 2021 12:11:33 -0700 (PDT)
From:   Stefano Stabellini <sstabellini@kernel.org>
To:     Randy Dunlap <rdunlap@infradead.org>
cc:     Stefano Stabellini <sstabellini@kernel.org>,
        Bhaskar Chowdhury <unixbhaskar@gmail.com>,
        linux@armlinux.org.uk, xen-devel@lists.xenproject.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        jgross@suse.com, boris.ostrovsky@oracle.com
Subject: Re: [PATCH] ARM: xen/mm.c: A mundane typo fix
In-Reply-To: <5e1b573a-6dc7-7f28-28ae-c509e6782fbf@infradead.org>
Message-ID: <alpine.DEB.2.21.2103241203140.439@sstabellini-ThinkPad-T480s>
References: <20210324133036.17665-1-unixbhaskar@gmail.com> <alpine.DEB.2.21.2103241154320.439@sstabellini-ThinkPad-T480s> <5e1b573a-6dc7-7f28-28ae-c509e6782fbf@infradead.org>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 24 Mar 2021, Randy Dunlap wrote:
> On 3/24/21 11:55 AM, Stefano Stabellini wrote:
> > On Wed, 24 Mar 2021, Bhaskar Chowdhury wrote:
> >> s/acrros/across/
> >>
> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> > 
> > Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> > 
> > 
> 
> Hi,
> It seems to me like some of those "page" should be "pages".

Yes, good point actually


> >> ---
> >>  arch/arm/xen/mm.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/xen/mm.c b/arch/arm/xen/mm.c
> >> index 467fa225c3d0..be7c942c74bf 100644
> >> --- a/arch/arm/xen/mm.c
> >> +++ b/arch/arm/xen/mm.c
> >> @@ -105,7 +105,7 @@ bool xen_arch_need_swiotlb(struct device *dev,
> >>  	 *	- The Linux page refers to foreign memory
> >>  	 *	- The device doesn't support coherent DMA request
> >>  	 *
> >> -	 * The Linux page may be spanned acrros multiple Xen page, although>> +	 * The Linux page may be spanned across multiple Xen page, although
> 
> 	                                                     pages,
> 
> >>  	 * it's not possible to have a mix of local and foreign Xen page.
> 
> 	                                                            pages.

yes to both


> >>  	 * Furthermore, range_straddles_page_boundary is already checking
> >>  	 * if buffer is physically contiguous in the host RAM.
> >> --
> 
> 
> -- 
> ~Randy
>